-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microservice gateway env variable is required, but it could not be deployed #185
Comments
What about dismissing (after a deprecation period) |
Interesting idea, it's quite a big breaking change but it could be handled in some way. We could handle it in this way:
We could also change the http client used under the hood with an http client more extensible, like axios or got |
Implemented the http client method. At the next major (v6), we could remove the MICROSERVICE_GATEWAY_SERVICE_NAME env variables as, when removed the |
Description
Here the MICROSERVICE_GATEWAY_SERVICE_NAME env variable is set as required, but the service could not exist.
The presence of this variable could bring to use the
getServiceProxy
function, which url is set to the microservice-gateway (which is unreachable).An example usecase is a project which initially contains the microservice-gateway, and at a later time it will be removed. If a service called to the microservice-gateway, it throws with some error.
Proposed feature
My proposal is to set the
MICROSERVICE_GATEWAY_SERVICE_NAME
env variable as not required.If it is set (and it is not empty), the
getServiceProxy
remains as today (so themicroservice-gateway
service is called).If, on the other hand, the env variable is not set (or is empty) and the service calls the
getServiceProxy
method, the service will throw a clear error. In this way, it is possible to catch the issue with the explaination on how to fix it.If possible, it would be great if throwed error could be raised on service startup.
The text was updated successfully, but these errors were encountered: