diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 9cca010..54d80a9 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -4,7 +4,7 @@ "containerUser": "root", "features": { "ghcr.io/devcontainers/features/common-utils:2": {}, - "ghcr.io/devcontainers/features/go:1": {"version": "none", "golangciLintVersion": "1.58.1"} + "ghcr.io/devcontainers/features/go:1": {"version": "none", "golangciLintVersion": "1.59.0"} }, "runArgs": [ "--cap-add=SYS_PTRACE", diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b37c41f..8c0214e 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -14,18 +14,18 @@ on: - examples/** env: - GORELEASER_VERSION: v1.26.1 + GORELEASER_VERSION: v1.26.2 jobs: lint: name: Lint Code runs-on: ubuntu-latest steps: - name: Checkout Repository - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 + uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6 with: show-progress: false - name: Setup Golang - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 with: go-version-file: go.mod cache: false @@ -54,11 +54,11 @@ jobs: runs-on: ${{ matrix.os }} steps: - name: Checkout Repository - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 + uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6 with: show-progress: false - name: Setup Golang - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 with: go-version-file: go.mod - name: Run Test Coverage @@ -73,15 +73,15 @@ jobs: if: github.event_name != 'push' steps: - name: Checkout Repository - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 + uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6 with: show-progress: false - name: Setup Golang - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 with: go-version-file: go.mod - name: Setup Goreleaser - uses: goreleaser/goreleaser-action@7ec5c2b0c6cdda6e8bbb49444bc797dd33d74dd8 # v5.0.0 + uses: goreleaser/goreleaser-action@5742e2a039330cbb23ebf35f046f814d4c6ff811 # v5.1.0 with: version: ${{ env.GORELEASER_VERSION }} install-only: true @@ -96,16 +96,16 @@ jobs: if: github.event_name == 'push' steps: - name: Checkout Repository - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 + uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6 with: show-progress: false fetch-depth: 0 - name: Setup Golang - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 with: go-version-file: go.mod - name: Setup Goreleaser - uses: goreleaser/goreleaser-action@7ec5c2b0c6cdda6e8bbb49444bc797dd33d74dd8 # v5.0.0 + uses: goreleaser/goreleaser-action@5742e2a039330cbb23ebf35f046f814d4c6ff811 # v5.1.0 with: version: ${{ env.GORELEASER_VERSION }} install-only: true @@ -129,7 +129,7 @@ jobs: - publish-release steps: - name: Checkout Repository - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 + uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6 with: show-progress: false - name: Download Binaries @@ -141,13 +141,13 @@ jobs: run: | find ./bin/{darwin,linux} -type f -exec chmod +x {} \; - name: Docker Login to GitHub Repository - uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20 # v3.1.0 + uses: docker/login-action@0d4c9c5ea7693da7b068278f7b52bda2a190a446 # v3.2.0 with: registry: ghcr.io username: ${{ github.repository_owner }} password: ${{ secrets.GITHUB_TOKEN }} - name: Docker Login to DockerHub - uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20 # v3.1.0 + uses: docker/login-action@0d4c9c5ea7693da7b068278f7b52bda2a190a446 # v3.2.0 with: username: ${{ secrets.BOT_DOCKER_USERNAME }} password: ${{ secrets.BOT_DOCKER_TOKEN }} diff --git a/.github/workflows/codeql.yaml b/.github/workflows/codeql.yaml index bb6c10c..f222038 100644 --- a/.github/workflows/codeql.yaml +++ b/.github/workflows/codeql.yaml @@ -16,7 +16,7 @@ on: - cron: 0 5 * * 1 # Run every monday at 5 UTC env: - GORELEASER_VERSION: v1.26.1 + GORELEASER_VERSION: v1.26.2 jobs: codeql: @@ -25,23 +25,23 @@ jobs: security-events: write steps: - name: Checkout repository - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 + uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6 with: show-progress: false - name: Setup Golang - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0 + uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1 with: go-version-file: go.mod - name: Setup Goreleaser - uses: goreleaser/goreleaser-action@7ec5c2b0c6cdda6e8bbb49444bc797dd33d74dd8 # v5.0.0 + uses: goreleaser/goreleaser-action@5742e2a039330cbb23ebf35f046f814d4c6ff811 # v5.1.0 with: version: ${{ env.GORELEASER_VERSION }} install-only: true - name: Initialize CodeQL - uses: github/codeql-action/init@d39d31e687223d841ef683f52467bd88e9b21c14 # v3.25.3 + uses: github/codeql-action/init@f079b8493333aace61c81488f8bd40919487bd9f # v3.25.7 with: languages: go - name: Run Build run: make build - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@d39d31e687223d841ef683f52467bd88e9b21c14 # v3.25.3 + uses: github/codeql-action/analyze@f079b8493333aace61c81488f8bd40919487bd9f # v3.25.7 diff --git a/.github/workflows/dependency-review.yaml b/.github/workflows/dependency-review.yaml index dd7138b..ff54183 100644 --- a/.github/workflows/dependency-review.yaml +++ b/.github/workflows/dependency-review.yaml @@ -17,11 +17,11 @@ jobs: pull-requests: write steps: - name: Checkout Repository - uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4 + uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6 with: show-progress: false - name: Dependency Review - uses: actions/dependency-review-action@5bbc3ba658137598168acb2ab73b21c432dd411b # v4.2.5 + uses: actions/dependency-review-action@0c155c5e8556a497adf53f2c18edabf945ed8e70 # v4.3.2 with: fail-on-scope: runtime,development,unknown comment-summary-in-pr: on-failure diff --git a/Makefile b/Makefile index f23c30f..b945ad2 100644 --- a/Makefile +++ b/Makefile @@ -49,7 +49,7 @@ endif # Set here the name of the package you want to build CMDNAME:= vab -BUILD_PATH:= . +BUILD_PATH:= ./cmd/vab CONFORMANCE_TEST_PATH:= $(PROJECT_DIR)/internal/e2e IS_LIBRARY:= diff --git a/pkg/validate/validate.go b/pkg/validate/validate.go index ad36450..3489fab 100644 --- a/pkg/validate/validate.go +++ b/pkg/validate/validate.go @@ -155,7 +155,6 @@ func checkClusters(logger logger.LogInterface, group *v1alpha1.Group, groupName } for _, cluster := range group.Clusters { - cluster := cluster clusterName := cluster.Name if clusterName == "" { outString += fmt.Sprintf("[error][%s] missing cluster name in group: please specify a valid name for each cluster\n", groupName) diff --git a/tools/GOLANGCI_LINT_VERSION b/tools/GOLANGCI_LINT_VERSION index 1c55d04..2abfc1f 100644 --- a/tools/GOLANGCI_LINT_VERSION +++ b/tools/GOLANGCI_LINT_VERSION @@ -1 +1 @@ -v1.58.1 +v1.59.0 diff --git a/tools/GORELEASER_VERSION b/tools/GORELEASER_VERSION index 71fa1b8..6ce99ef 100644 --- a/tools/GORELEASER_VERSION +++ b/tools/GORELEASER_VERSION @@ -1 +1 @@ -v1.26.1 +v1.26.2