fix: ensure env vals are strings

Author: jaydesl

submitter/adaptors/k8s_adaptor/resources/base.py

@@ -1,3 +1,5 @@
+from ruamel.yaml.scalarstring import DoubleQuotedScalarString as quoted_str
+
 WORKLOADS = ("Deployment", "DaemonSet", "StatefulSet", "Job", "Pod")
 
 class Resource:
@@ -169,3 +171,21 @@ def __init__(self, app, name, manifest):
         self.spec = self.manifest.get("spec", {}).get("template", {}).get(
             "spec", None
         ) or self.manifest.get("spec", {})
+        if "containers" in self.spec:
+            traverse_and_modify(self.spec["containers"])
+
+def stringify_env_values(env_list):
+    for env_var in env_list:
+        if "value" in env_var:
+            env_var['value'] = quoted_str(env_var['value'])
+
+def traverse_and_modify(obj):
+    if isinstance(obj, dict):
+        for key, value in obj.items():
+            if key == 'env' and isinstance(value, list):
+                stringify_env_values(value)
+            else:
+                traverse_and_modify(value)
+    elif isinstance(obj, list):
+        for item in obj:
+            traverse_and_modify(item)

submitter/adaptors/k8s_adaptor/resources/container.py

@@ -1,5 +1,7 @@
 import shlex
 
+from ruamel.yaml.scalarstring import DoubleQuotedScalarString as quoted_str
+
 # Swarm properties unsupported by Kubernetes and/or this adaptor
 SWARM_PROPERTIES = (
     "configs",
@@ -85,7 +87,7 @@ def _translate_docker_properties(self):
         self.spec.setdefault("env", _make_env(self.spec.pop("environment", {})))
         for env in self.spec.get("env", []):
             if "value" in env:
-                env["value"] = str(env["value"])
+                env["value"] = quoted_str(env["value"])
 
         self.spec.setdefault("stdin", self.spec.pop("stdin_open", None))
         self.spec.setdefault("workingDir", self.spec.pop("working_dir", None))