diff --git a/CHANGELOG.md b/CHANGELOG.md index 021ced4..dfcdf30 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log All notable changes to this project will be documented in this file. +## [3.1.2] - 2024-04-28 +### Updated +- Fixed incorrect error message for invalid DMARC ruf. +- Cleaned-up language file. + ## [3.1.1] - 2024-04-23 ### Added - Github CI Workflows. diff --git a/lang/en/local_mailtest.php b/lang/en/local_mailtest.php index f0d6264..db9aa0a 100644 --- a/lang/en/local_mailtest.php +++ b/lang/en/local_mailtest.php @@ -25,80 +25,66 @@ defined('MOODLE_INTERNAL') || die(); -$string['pluginname'] = 'eMail Test'; -$string['privacy:metadata'] = 'The eMail Test plugin does not store any personal data about any user.'; -$string['pluginname_help'] = 'eMail Test will verify the email settings for this Moodle site by sending a test email message to the address you specify. For Site Administrators only.'; -$string['credit'] = 'Michael Milette - TNG Consulting Inc.'; - -$string['from'] = '{$a->type}: {$a->email} ({$a->label})'; -$string['heading'] = 'Email configuration test'; -$string['testing'] = 'Testing email configuration'; -$string['recipientisrequired'] = 'You must specify the recipient\'s email address.'; -$string['server'] = 'Server: {$a}'; - -$string['emailfail'] = 'Failed to send email message'; -$string['errorsend'] = '

The test email message could not be delivered to the mail server.

Recommendations:

Check your Moodle Email settings. For more help, see the FAQ section in the documentation. You may also wish to reference the list of SMTP codes in RFC 5321 and RFC 4954.

'; -$string['errorcommunications'] = '

Moodle could not communicate with your mail server.

Recommendations:

Start by checking your Moodle SMTP mail settings.

If they look correct, check your SMTP Server and/or firewall settings to ensure that they are configured to accept SMTP connections from your Moodle web server and your no-reply email address. For more help, see the FAQ section in the documentation.

'; -$string['errorunknown'] = '

An undiagnosed error occured.

Recommendations:

Refer to the communications log below. You may find it useful to reference the list of SMTP codes in RFC 5321 and RFC 4954.

'; - -$string['fromemail'] = 'From email address'; -$string['toemail'] = 'To email address'; -$string['youremail'] = 'Your email address'; -$string['primaryadminemail'] = 'Primary admin email'; +$string['additionalinfo'] = 'Additional information:'; $string['alwaysshowlog'] = 'Always show log of communications with mail server, even if there are no errors.'; -$string['sendtest'] = 'Send a test message'; -$string['sendmethod'] = 'Email send method'; -$string['sentmail'] = 'Moodle successfully delivered the test message to the SMTP mail server.'; -$string['sentmailphp'] = 'The Moodle test message was successfully accepted by PHP Mail.'; -$string['registered'] = 'Registered user ({$a}).'; -$string['notregistered'] = 'Not registered or not logged in.'; -$string['phpmethod'] = 'PHP default method'; -$string['connectionlog'] = 'Communications log with mail server'; - -$string['iconlabel'] = 'Security check for {$a}'; +$string['bimidmarcfailure'] = 'BIMI failure due to one or more DMARC dependency failures.'; +$string['bimiinvalidlogo'] = 'Missing BIMI logo: {$a}.'; +$string['biminorecordfound'] = 'BIMI record is missing.'; +$string['bimipctinvalid'] = 'DMARC PCT value must be set to 100 for BIMI.'; +$string['bimirecordfound'] = 'BIMI record found.'; +$string['bimitagsfound'] = 'BIMI tags valid.'; $string['checkingdomain'] = 'DNS security check for {$a}:'; -$string['spfrecordfound'] = 'SPF record found.'; -$string['spfnorecordfound'] = 'SPF record is missing.'; -$string['spfvalidrecord'] = 'SPF record format is valid.'; -$string['spfinvalidrecord'] = 'SPF record must contains at least one mechanism.'; -$string['dkimrecordfound'] = 'DKIM record found.'; -$string['dkimnorecordfound'] = 'DKIM record is missing.'; -$string['dkimvalidrecord'] = 'DKIM record format is valid.'; +$string['commoncommissues'] = ' +
  • Your Moodle site may be blocked by a firewall, preventing communication with your mail server.
    • +
  • You may need to add the IP address of your website to a list of allowed IP addresses in your mail server\'s configuration.
    • +
  • Ensure that your SMTP server is up and running.
    • +'; +$string['commondeliveryissues'] = 'If the email is not delivered within about 15-30 minutes, check the following:

    +'; +$string['connectionlog'] = 'Communications log with mail server'; +$string['credit'] = 'Michael Milette - TNG Consulting Inc.'; +$string['divertallemails'] = 'Divert all emails'; +$string['divertedto'] = 'Diverted to {$a}'; $string['dkiminvalidrecord'] = 'DKIM record must contains valid v, k and p tags.'; -$string['dkimselectorconfigured'] = 'DKIM selector setting is configured.'; $string['dkimmissingselector'] = 'DKIM selector setting has not been configured.'; +$string['dkimnorecordfound'] = 'DKIM record is missing.'; +$string['dkimrecordfound'] = 'DKIM record found.'; +$string['dkimselectorconfigured'] = 'DKIM selector setting is configured.'; $string['dkimspffailed'] = 'DMARC requires that SPF or DKIM records be configured.'; -$string['dmarcrecordfound'] = 'DMARC record found.'; +$string['dkimvalidrecord'] = 'DKIM record format is valid.'; $string['dmarcnorecordfound'] = 'DMARC record is missing.'; -$string['dmarctagsfound'] = 'DMARC required tags found.'; -$string['dmarctagsnotfound'] = 'DMARC record must contain valid v and p tags.'; +$string['dmarcpctinvalid'] = 'DMARC pct value is not within range.'; +$string['dmarcrecordfound'] = 'DMARC record found.'; $string['dmarcruainvalid'] = 'DMARC rua value is not formatted correctly.'; $string['dmarcrufinvalid'] = 'DMARC ruf value is not formatted correctly.'; -$string['dmarcpctinvalid'] = 'DMARC pct value is not within range.'; -$string['bimipctinvalid'] = 'DMARC PCT value must be set to 100 for BIMI.'; -$string['biminorecordfound'] = 'PCT must be set to 100 for BIMI.'; -$string['bimirecordfound'] = 'BIMI record found.'; -$string['biminorecordfound'] = 'BIMI record is missing.'; -$string['bimiinvalidlogo'] = 'Missing BIMI logo: {$a}.'; -$string['bimitagsfound'] = 'BIMI tags valid.'; -$string['bimidmarcfailure'] = 'BIMI failure due to one or more DMARC dependency failures.'; -$string['recordfoundnovalidation'] = 'This means that the record exists. However, no validation was done.'; - -$string['nologavailable'] = '

    Logging is not available when using PHP mail() function. However, may find logs on your server. Most common locations on Linux include:

    - -

    Alernatively, a custom location may be specified using the mail.log setting in php.ini.

    '; - -$string['winsyslog'] = 'Event Log on Windows'; -$string['divertedto'] = 'Diverted to {$a}'; -$string['divertallemails'] = 'Divert all emails'; -$string['noemailever'] = '

    Email on this site has been disabled by way of $CFG->noemailever = true;.

    '; -$string['smtpmethod'] = 'SMTP hosts: {$a}'; - +$string['dmarctagsfound'] = 'DMARC required tags found.'; +$string['emailfail'] = 'Failed to send email message'; +$string['errorcommunications'] = '

    Moodle could not communicate with your mail server.

    Recommendations:

    Start by checking your Moodle SMTP mail settings.

    If they look correct, check your SMTP Server and/or firewall settings to ensure that they are configured to accept SMTP connections from your Moodle web server and your no-reply email address. For more help, see the FAQ section in the documentation.

    '; +$string['errorsend'] = '

    The test email message could not be delivered to the mail server.

    Recommendations:

    Check your Moodle Email settings. For more help, see the FAQ section in the documentation. You may also wish to reference the list of SMTP codes in RFC 5321 and RFC 4954.

    '; +$string['errorunknown'] = '

    An undiagnosed error occured.

    Recommendations:

    Refer to the communications log below. You may find it useful to reference the list of SMTP codes in RFC 5321 and RFC 4954.

    '; +$string['failaccessdenied'] = '
  • Connect to the mail server but it closed then closed connection.
    • '; +$string['failclosedport'] = 'Server port {$a} is closed. Did you specify the correct :port number?'; +$string['failcredentials'] = '
  • Authentication credentials may be invalid or missing. Make sure that you have entered the correct login information.
    • '; +$string['faildnslookup'] = 'DNS lookup failed. Ensure that \'{$a}\' resolves to the address of a mail server.'; +$string['failmissingport'] = 'You may need to specify a :port number for "{$a}" type connections.'; +$string['failmissingprotocol'] = 'You may need to specify a secure protocol type (SSL/TLS) with port \'{$a}\'.'; +$string['failoutboundsmtpblocked'] = 'Something is blocking connectivity of outbound SMTP connections. Is there a firewall blocking your connection to the mail server?'; +$string['failphpmailer'] = 'There may be issues with your installation of Moodle LMS. One possible reason is incorrect owner/group permissions of the application files.'; +$string['failphpmailerconfig'] = 'The mail service on the your Moodle web server may not be running or may be incorrectly configured.'; +$string['failprotocolmismatch'] = 'You may have a mismatch between the protocol \'{$a->protocol}\' and the port \'{$a->port}\'.'; +$string['failunknownmailbox'] = '
  • The FROM mailbox was not found, is not accessible, or was rejected for policy reasons. Make sure that both the TO and FROM email addresses are valid and exist and that the \'no-reply\' address is a real mailbox that exists on your mail server.
    • '; +$string['from'] = '{$a->type}: {$a->email} ({$a->label})'; +$string['fromemail'] = 'From email address'; +$string['heading'] = 'Email configuration test'; +$string['iconlabel'] = 'Security check for {$a}'; $string['message'] = '

    This is a test message. Please disregard.

    If you received this email, it means that you have successfully configured your Moodle site\'s email settings.

    Additional User Information

    @@ -110,33 +96,33 @@
  • Moodle version : {$a->release}
  • User\'s IP address : {$a->ip}
    • '; - -$string['additionalinfo'] = 'Additional information:'; -$string['failcredentials'] = '
  • Authentication credentials may be invalid or missing. Make sure that you have entered the correct login information.
    • '; -$string['failunknownmailbox'] = '
  • The FROM mailbox was not found, is not accessible, or was rejected for policy reasons. Make sure that both the TO and FROM email addresses are valid and exist and that the \'no-reply\' address is a real mailbox that exists on your mail server.
    • '; -$string['failaccessdenied'] = '
  • Connect to the mail server but it closed then closed connection.
    • '; -$string['faildnslookup'] = 'DNS lookup failed. Ensure that \'{$a}\' resolves to the address of a mail server.'; -$string['failclosedport'] = 'Server port {$a} is closed. Did you specify the correct :port number?'; -$string['failmissingport'] = 'You may need to specify a :port number for "{$a}" type connections.'; -$string['failmissingprotocol'] = 'You may need to specify a secure protocol type (SSL/TLS) with port \'{$a}\'.'; -$string['failprotocolmismatch'] = 'You may have a mismatch between the protocol \'{$a->protocol}\' and the port \'{$a->port}\'.'; -$string['failoutboundsmtpblocked'] = 'Something is blocking connectivity of outbound SMTP connections. Is there a firewall blocking your connection to the mail server?'; -$string['failphpmailer'] = 'There may be issues with your installation of Moodle LMS. One possible reason is incorrect owner/group permissions of the application files.'; -$string['failphpmailerconfig'] = 'The mail service on the your Moodle web server may not be running or may be incorrectly configured.'; - -$string['commondeliveryissues'] = 'If the email is not delivered within about 15-30 minutes, check the following:

    +$string['noemailever'] = '

    Email on this site has been disabled by way of $CFG->noemailever = true;.

    '; +$string['nologavailable'] = '

    Logging is not available when using PHP mail() function. However, may find logs on your server. Most common locations on Linux include:

    '; - -$string['commoncommissues'] = ' -
  • Your Moodle site may be blocked by a firewall, preventing communication with your mail server.
    • -
  • You may need to add the IP address of your website to a list of allowed IP addresses in your mail server\'s configuration.
    • -
  • Ensure that your SMTP server is up and running.
    • -'; +
  • /var/log/maillog
    • +
  • /var/log/mail.log
    • +
  • /var/adm/maillog
    • +
  • /var/adm/syslog/mail.log
    • + +

    Alernatively, a custom location may be specified using the mail.log setting in php.ini.

    '; +$string['notregistered'] = 'Not registered or not logged in.'; +$string['phpmethod'] = 'PHP default method'; +$string['pluginname_help'] = 'eMail Test will verify the email settings for this Moodle site by sending a test email message to the address you specify. For Site Administrators only.'; +$string['pluginname'] = 'eMail Test'; +$string['primaryadminemail'] = 'Primary admin email'; +$string['privacy:metadata'] = 'The eMail Test plugin does not store any personal data about any user.'; +$string['registered'] = 'Registered user ({$a}).'; +$string['sendmethod'] = 'Email send method'; +$string['sendtest'] = 'Send a test message'; +$string['sentmail'] = 'Moodle successfully delivered the test message to the SMTP mail server.'; +$string['sentmailphp'] = 'The Moodle test message was successfully accepted by PHP Mail.'; +$string['server'] = 'Server: {$a}'; +$string['smtpmethod'] = 'SMTP hosts: {$a}'; +$string['spfinvalidrecord'] = 'SPF record must contains at least one mechanism.'; +$string['spfnorecordfound'] = 'SPF record is missing.'; +$string['spfrecordfound'] = 'SPF record found.'; +$string['spfvalidrecord'] = 'SPF record format is valid.'; +$string['testing'] = 'Testing email configuration'; +$string['toemail'] = 'To email address'; +$string['winsyslog'] = 'Event Log on Windows'; +$string['youremail'] = 'Your email address'; diff --git a/locallib.php b/locallib.php index 27dd7bb..7c2c0d3 100644 --- a/locallib.php +++ b/locallib.php @@ -260,7 +260,7 @@ function local_mailtest_checkdns($domain) { // Validate ruf value format (should be a valid URI). if (!filter_var($rufvalue, FILTER_VALIDATE_URL) && !filter_var("mailto:" . $rufvalue, FILTER_VALIDATE_EMAIL)) { // The ruf value is not formatted correctly. - $message .= $xmark . get_string('dmarcruainvalid', 'local_mailtest') . '
    '; + $message .= $xmark . get_string('dmarcrufinvalid', 'local_mailtest') . '
    '; $success = false; } }