Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect title tag on most pages #5

Open
michael-milette opened this issue Jun 11, 2021 · 7 comments
Open

Incorrect title tag on most pages #5

michael-milette opened this issue Jun 11, 2021 · 7 comments
Labels
bug Something isn't working triaged

Comments

@michael-milette
Copy link
Owner

The title tag indicates the site short name followed by the page name on most of pages of the Moodle site. However, if you go into the theme settings and enable the Add site name to title option, the site's long name is appended to the shortname+page name.

  • If Add site name to title is disabled, the site name should not appear in the title tag.
  • If Add site name to title is enabled, the title tag should contain the page title followed by " - " and the site short name. Even better, create a setting to allow Administrator to choose between site shortname or fullname.
@michael-milette michael-milette added the bug Something isn't working label Jun 11, 2021
@michael-milette michael-milette changed the title Bug: Incorrect title tag on most pages Incorrect title tag on most pages Jun 11, 2021
@michael-milette
Copy link
Owner Author

michael-milette commented Jun 11, 2021

Note: The only page whose title seems to work correctly, as previously described, is the Home page (front page).

@michael-milette
Copy link
Owner Author

Looks like /course/ is showing as a category and actual categories are being identified as All Courses (logic should be reversed).

@michael-milette
Copy link
Owner Author

The problem with category pages has been resolved in #4 .

@michael-milette
Copy link
Owner Author

Cannot reproduce in my development environment.

If you are experiencing this issue, please let me know. Hopefully we can work together to determine what might be causing this issue only on certain Moodle sites.

@michael-milette michael-milette added the help wanted for testing Ready for QA Testing label Jun 22, 2021
@sameer-ah
Copy link

Hi @michael-milette,

Here is the result of my test cases.

Add site name to title is enabled:

  • On Site Administration page, the page title is shortname: Administration : Search - longname
  • On site Home page, the page title is Home - longname
  • On Dashboard page, the page title is Dashboard - longname

Add site name to title is disabled:

  • On Site Administration page, the page title is shortname: Administration : Search
  • On site Home page, the page title is Home
  • On Dashboard page, the page title is Dashboard

Please let me know in case more test cases are needed or I can provide any other help to fix this issue.

Thank you,
Sameer

@michael-milette
Copy link
Owner Author

So it sounds like it is working properly. Thanks for checking @sameer-ah .

@michael-milette
Copy link
Owner Author

Ignore my last message. I just noticedthat the short and long names are on the Site Administration page. Thanks again for your help.

@michael-milette michael-milette added triaged and removed help wanted for testing Ready for QA Testing labels Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged
Projects
None yet
Development

No branches or pull requests

2 participants