From b1f2290811e95d706d4969e7bec2a0f24b32142a Mon Sep 17 00:00:00 2001 From: Michael Bromley Date: Fri, 1 Apr 2016 10:21:39 +0200 Subject: [PATCH] Update to v0.11.1 See release notes --- README.md | 5 +++++ bower.json | 2 +- dirPagination.js | 15 ++++++++++----- package.js | 2 +- package.json | 2 +- 5 files changed, 18 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 3045c27..8a6ff75 100644 --- a/README.md +++ b/README.md @@ -8,6 +8,11 @@ dependency management via Bower, npm and other package managers. All documentation is also located in the [angularUtils project](https://github.com/michaelbromley/angularUtils/tree/master/src/directives/pagination). +## Changelog + +Please see the [releases page](https://github.com/michaelbromley/angularUtils-pagination/releases) for details +of each released version. + ## Issues Please submit any issues to the [angularUtils issue tracker](https://github.com/michaelbromley/angularUtils/issues), not this one. diff --git a/bower.json b/bower.json index 71bacea..6ad9bf2 100644 --- a/bower.json +++ b/bower.json @@ -1,6 +1,6 @@ { "name": "angularUtils-pagination", - "version": "0.11.0", + "version": "0.11.1", "homepage": "https://github.com/michaelbromley/angularUtils/tree/master/src/directives/pagination", "authors": [ "Michael Bromley " diff --git a/dirPagination.js b/dirPagination.js index bbb6216..a1a7265 100644 --- a/dirPagination.js +++ b/dirPagination.js @@ -68,9 +68,12 @@ // Now that we have access to the `scope` we can interpolate any expression given in the paginationId attribute and // potentially register a new ID if it evaluates to a different value than the rawId. var paginationId = $parse(attrs.paginationId)(scope) || attrs.paginationId || DEFAULT_ID; + + // (TODO: this seems sound, but I'm reverting as many bug reports followed it's introduction in 0.11.0. + // Needs more investigation.) // In case rawId != paginationId we deregister using rawId for the sake of general cleanliness // before registering using paginationId - paginationService.deregisterInstance(rawId); + // paginationService.deregisterInstance(rawId); paginationService.registerInstance(paginationId); var repeatExpression = getRepeatExpression(expression, paginationId); @@ -105,12 +108,14 @@ // Delegate to the link function returned by the new compilation of the ng-repeat compiled(scope); - + + // (TODO: Reverting this due to many bug reports in v 0.11.0. Needs investigation as the + // principle is sound) // When the scope is destroyed, we make sure to remove the reference to it in paginationService // so that it can be properly garbage collected - scope.$on('$destroy', function destroyDirPagination() { - paginationService.deregisterInstance(paginationId); - }); + // scope.$on('$destroy', function destroyDirPagination() { + // paginationService.deregisterInstance(paginationId); + // }); }; } diff --git a/package.js b/package.js index f33baf6..34664ac 100644 --- a/package.js +++ b/package.js @@ -1,7 +1,7 @@ Package.describe({ name: 'angularutils:pagination', summary: 'Magical automatic pagination for anything in AngularJS', - version: '0.11.0', + version: '0.11.1', git: 'https://github.com/michaelbromley/angularUtils-pagination' }); diff --git a/package.json b/package.json index f9cb828..abfe428 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "angular-utils-pagination", - "version": "0.11.0", + "version": "0.11.1", "description": "Magical automatic pagination for anything in AngularJS", "main": "index.js", "scripts": {