expand daemon/planet test coverage

Author: michaelprograms

lib/daemon/planet.c

@@ -71,19 +71,19 @@ int create_planet (string name, mapping config) {
     }
     config["name"] = name;
     __Planet = config;
-    return save_object(path);
+    return !!save_object(path);
 }
 
 int adjust_planet (string name, mapping config) {
     string path = "/save/planet/" + lower_case(name[0..0]) + "/" + name + ".o";
-    if (file_size(path) == 0) {
+    if (file_size(path) == -1) {
         return 0;
     }
     __Planet = ([ ]);
     map_delete(config, "name");
     restore_object(path);
     __Planet += config;
-    return save_object(path);
+    return !!save_object(path);
 }
 
 /* ----- noise ----- */

lib/daemon/planet.test.c

@@ -108,4 +108,27 @@ void test_querying_planets () {
         assert_equal(testOb->query_planet("Terra")["name"], "Terra"),
         assert_equal(testOb->query_planet_size("Terra"), 500),
     }) :));
+}
+
+void test_creating_and_adjusting_planet () {
+    string testPlanet = "test_" + time();
+
+    expect("create_planet behaves", (: ({
+        // planet doesn't exist yet
+        assert_equal(testOb->query_planet($(testPlanet)), ([ ])),
+        // create test planet
+        assert_equal(testOb->create_planet($(testPlanet), ([ "size": 123 ])), 1),
+        // planet exists
+        assert_equal(testOb->query_planet($(testPlanet)), ([ "name": $(testPlanet), "size": 123 ])),
+        // planet was already created
+        assert_equal(testOb->create_planet($(testPlanet), ([ ])), 0),
+    }) :));
+    expect("adjust_planet behaves", (: ({
+        // adjust planet size
+        assert_equal(testOb->adjust_planet($(testPlanet), ([ "size": 321 ])), 1),
+        // can't adjust non-existant planet
+        assert_equal(testOb->adjust_planet($(testPlanet+"-bad"), ([ "size": 321 ])), 0),
+    }) :));
+
+    rm("/save/planet/t/"+testPlanet+".o");
 }