Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncessary dependencies in the pyproject.toml ? #40

Open
moorepants opened this issue Aug 7, 2024 · 0 comments
Open

Uncessary dependencies in the pyproject.toml ? #40

moorepants opened this issue Aug 7, 2024 · 0 comments

Comments

@moorepants
Copy link

Hi,

When trying to package the new biogeme on conda forge we see many new dependencies in the pyproject.toml file and notice that some may not be hard dependencies:

  • IPython is only used in the examples
  • No Jinja2 imports are found in the source code at all
  • python-levenshtein does not seem to be imported in the source code anywhere
  • tomlkit and fuzzywuzzy seem to be imported once, could these be made into optional dependencies?

Also, does the package really not work with NumPy < 2? NumPy 2 is very new and putting such a restriction makes it hard to install in many environments because the whole ecosystem hasn't fully adopted NumPy 2 yet. For example, we hope to include this in the software installations at TU Delft in the computer labs but we will be running NumPy 1 for this coming year, as 2 can't be installed with many packages in our distribution.

Lastly, are the upper bound pins really necessary? This also creates unnecessary restrictions and makes it difficult to install the package in environments with other software. (TDLR about this topic: https://iscinumpy.dev/post/bound-version-constraints/)

Thanks,

Jason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant