From 4be4bd22a2bfbab3e2bd7b9998d971ba89f43748 Mon Sep 17 00:00:00 2001 From: mickamy Date: Mon, 8 Jan 2024 11:30:04 +0900 Subject: [PATCH 1/3] ci: run build and push images after benchmark --- .github/workflows/build_and_push_images.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build_and_push_images.yml b/.github/workflows/build_and_push_images.yml index fc63140..62c49dd 100644 --- a/.github/workflows/build_and_push_images.yml +++ b/.github/workflows/build_and_push_images.yml @@ -3,16 +3,19 @@ name: Build and push images on: workflow_dispatch: push: - branches: - - master + workflow_run: + workflows: ["Benchmark"] + types: + - completed concurrency: group: ${{ github.workflow }}-${{ github.sha }} cancel-in-progress: true jobs: - build-and-push-base-and-bench-images: + build-base-and-bench-images: name: Build and push base and bench images + if: ${{ github.event.workflow_run.conclusion == 'success' }} runs-on: ubuntu-latest timeout-minutes: 60 env: @@ -69,7 +72,7 @@ jobs: name: Build app images runs-on: ubuntu-latest timeout-minutes: 60 - needs: build-and-push-base-and-bench-images + needs: build-base-and-bench-images strategy: fail-fast: false matrix: From d1b941e1d83eb377a3f9cd7ede5d944fd5ffa0ee Mon Sep 17 00:00:00 2001 From: mickamy Date: Mon, 8 Jan 2024 12:01:18 +0900 Subject: [PATCH 2/3] revert_me: test only with go for it is fastest --- .github/workflows/benchmark.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 3f4e913..fdbc55c 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -17,12 +17,12 @@ jobs: fail-fast: false matrix: language: - - "crystal" + # - "crystal" - "go" - - "nodejs" - - "php" - - "python" - - "ruby" + # - "nodejs" + # - "php" + # - "python" + # - "ruby" env: ISHOCON_APP_LANG: ${{ matrix.language }} UNAME: ${{ secrets.DOCKER_HUB_USERNAME }} From bddc93a9fca75f87499459fb876b73b9c63a7476 Mon Sep 17 00:00:00 2001 From: mickamy Date: Mon, 8 Jan 2024 12:07:57 +0900 Subject: [PATCH 3/3] ci: try workflow_run#branches --- .github/workflows/build_and_push_images.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_and_push_images.yml b/.github/workflows/build_and_push_images.yml index 62c49dd..5dba57c 100644 --- a/.github/workflows/build_and_push_images.yml +++ b/.github/workflows/build_and_push_images.yml @@ -2,9 +2,9 @@ name: Build and push images on: workflow_dispatch: - push: workflow_run: - workflows: ["Benchmark"] + workflows: [ Benchmark ] + branches: [ '**' ] types: - completed