closing entity managers

[webczat]

Shouldn't entity managers be closed? I know that container managed entity managers cannot be closed by application as per the requirements stated in jpa spec. However, isn't it the case that the container should close it? entity managers are created by "EntityManagerFactory.createEntityManager" all the time, and these are described as creating application managed entity managers, so i guess container can close them, and would have to wrap them in a layer that prevents closing. Not sure how true that is.

[ljnelson]

Hello and thanks for using microBean JPA CDI. As noted in the last paragraph of the README, this project is often deployed with a (necessarily) CDI-provider-specific counterpart (for Weld, this is microbean-jpa-weld-se). You'll note that the actual business of acquiring EntityManagers at runtime is not handled by this project, but by its counterpart.

It is not clear to me that an EntityManager created by the container with a JTA transaction type should ever be closed. Invoking operations on it when a transaction is not in effect will throw an error.

[ljnelson]

For a similar take, see Wildfly's implementation. Note in particular that JTA EntityManagers are closed only when the transaction completes.

Additionally, I think that EclipseLink (as one example) "closes" the underlying machinery itself. See, for example:

https://github.com/eclipse-ee4j/eclipselink/blob/3668d1a81e3e13d28a63b930de10bece725b0ed5/foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/transaction/AbstractSynchronizationListener.java#L236

I do need to track all this down and make sure that no resources are being leaked.

[ljnelson]

Glassfish does similar things.