Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deprecate the @Health annotation #148

Closed
derekm opened this issue Oct 18, 2018 · 3 comments
Closed

Don't deprecate the @Health annotation #148

derekm opened this issue Oct 18, 2018 · 3 comments

Comments

@derekm
Copy link
Contributor

derekm commented Oct 18, 2018

With strict 1.0-compliant behavior, the benefit of the @Health annotation is a quick & obvious way to disable health checks.

Keeping @Health also provides a place for group names to be defined as in issue #81 about executing health check groups or individual checks.

MicroProfile Health implementations will from now on forever reference the @Health annotation, so why get rid of it so quickly?

Forgive me for saying this, but a lot of activity in MP Health's master branch seems to be microscopic nitpicking, second-guessing and flip-flopping, instead of big picture, move-the-ball-down-the-court kind of stuff.

The ship has already sailed with MicroProfile Health 1.0. Implementations will now forever refer to an annotation that is instantly deprecated, which seems wasteful.

@derekm
Copy link
Contributor Author

derekm commented Oct 18, 2018

The introduction of @Readiness and @Liveness annotations in some sense demands keeping the @Health annotation.

See my comment with rationale here on the liveness/readiness PR: #142 (comment)

@mkouba
Copy link

mkouba commented Feb 14, 2019

With strict 1.0-compliant behavior, the benefit of the @Health annotation is a quick & obvious way to disable health checks.

There is a "quick and obvious" way of disabling beans in CDI - @Vetoed. See also http://docs.jboss.org/cdi/spec/2.0/cdi-spec.html#what_classes_are_beans.

Keeping @Health also provides a place for group names to be defined...

I believe it should be a dedicated qualifier with a meaningful name.

@antoinesd
Copy link
Contributor

out of date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants