Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: remove unused gradient and barrier op collecting #7150

Open
tex3d opened this issue Feb 20, 2025 · 0 comments
Open

Validation: remove unused gradient and barrier op collecting #7150

tex3d opened this issue Feb 20, 2025 · 0 comments
Labels
bug Bug, regression, crash needs-triage Awaiting triage validation Related to validation or signing

Comments

@tex3d
Copy link
Contributor

tex3d commented Feb 20, 2025

These gradientOps and barriers sets are unused:

SmallVector<CallInst *, 16> gradientOps;
SmallVector<CallInst *, 16> barriers;

Other than collecting operations into them:

if (OP::IsDxilOpGradient(dxilOpcode)) {
gradientOps.push_back(CI);
}
if (dxilOpcode == DXIL::OpCode::Barrier) {
barriers.push_back(CI);
}

They look like they were meant to be used for something, but there is no code using them, so they should be removed.

@tex3d tex3d added bug Bug, regression, crash needs-triage Awaiting triage validation Related to validation or signing labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, regression, crash needs-triage Awaiting triage validation Related to validation or signing
Projects
Status: No status
Development

No branches or pull requests

1 participant