Skip to content
This repository has been archived by the owner on Jul 19, 2024. It is now read-only.

Video recording is broken #309

Open
joranmarcy opened this issue Oct 25, 2018 · 5 comments
Open

Video recording is broken #309

joranmarcy opened this issue Oct 25, 2018 · 5 comments
Assignees

Comments

@joranmarcy
Copy link

joranmarcy commented Oct 25, 2018

Hi everyone,

I managed to make the spectator view work with Unity 2017.4.11f with the most up to date code from the master branch. The problem is that the mp4 file generated by the video record feature is corrupted.

Only the first second of the video is fine and then the image is stuck with some artifacts popping.

I tried to use an old version of the companion toolkit (1.5.7.0) and I don't have this issue.

Does anyone know what could be the problem ?

Thanks,
Joran.

@joranmarcy
Copy link
Author

joranmarcy commented Oct 26, 2018

Here is an example of the resulting video :

5_Video.zip

@joranmarcy
Copy link
Author

joranmarcy commented Oct 26, 2018

Ok, I reverted my local master branch to this commit : 3278d79

Commit name : Restart the spatial mapping observer when new data is requested.

Now it is working.

@joranmarcy
Copy link
Author

Several commits like :
2a31bd4
change the video encoder class. The issue might be here.

@joranmarcy
Copy link
Author

I confirm, 2a31bd4 is the commit causing trouble with video recording.

@chrisfromwork
Copy link
Contributor

@fieldsJacksonG any thoughts on what may be causing this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants