Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Long-term Moq strategy #1683

Open
codeofdusk opened this issue Aug 28, 2023 · 3 comments
Open

[Feature Request] Long-term Moq strategy #1683

codeofdusk opened this issue Aug 28, 2023 · 3 comments
Labels
feature request New feature or request

Comments

@codeofdusk
Copy link
Contributor

This applies to both Accessibility Insights for Windows and Axe.Windows, filing here for tracking of both.

Is your feature request related to a problem? Please describe.
Since 4.20.x, Moq has introduced a privacy vulnerability that improperly handles user data, see moq/moq#1372. In #1677 and microsoft/axe-windows#963, @madalynrose pinned our Moq version to 4.18.4.

Describe the solution you'd like
We should consider switching to an alternative unit testing library such as NSubstitute or a community backed Moq fork when or if one emerges. If we choose NSubstitute, we might be able to automate part of the migration. It might make sense to do such a migration in stages, similar to microsoft/accessibility-insights-web#2869.

Describe alternatives you've considered
Continue to use Moq 4.18 indefinitely, with an understanding that we will likely be unable to take any updates to the library going forward.

@codeofdusk codeofdusk added feature request New feature or request status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. labels Aug 28, 2023
@codeofdusk codeofdusk self-assigned this Aug 28, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@DaveTryon DaveTryon moved this from Needs triage to Tabled in Accessibility Insights Aug 28, 2023
@DaveTryon
Copy link
Contributor

We want to wait and see what happens with the broader community on this

@DaveTryon DaveTryon removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Aug 28, 2023
@ChristoWolf
Copy link

ChristoWolf commented Jan 29, 2024

I have worked with Moq, NSubstitute and FakeItEasy over the years and I have to say that I prefer FakeItEasy by far.

Also, not only was the Moq fiasco legally dubious, but they even used their versions for memeing (v4.20 instead of v4.19, v4.20.69).
Such things are not a great look when you have to provide SBOMs to regulatory bodies and customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Development

No branches or pull requests

4 participants