Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCommitDiffs does not accept the whole payload #573

Closed
Om4n3k opened this issue Oct 19, 2023 · 2 comments
Closed

getCommitDiffs does not accept the whole payload #573

Om4n3k opened this issue Oct 19, 2023 · 2 comments

Comments

@Om4n3k
Copy link

Om4n3k commented Oct 19, 2023

Environment

Node version: 18.14.2
Yarn version: 1.22.19
OS and version: Win 11
azure-devops-node-api version: 12.1.0

Issue Description

getCommitDiffs from gitApi ignores baseVersionDescriptor and targetVersionDescriptor payloads
gitClient.getCommitDiffs(this.repoId, this.project, true, 100, 0, { baseVersion: 'ADC_Wizard_15894, }, { targetVersion: 'main' })
Even after adding another properties (baseVersionType, baseVersionOptions, etc.), following URL gets generated:
image

Expected behaviour

The url should look like this
image
There should be differences between those branches
image

Actual behaviour

There are no differences found due to missing base and target branches

Steps to reproduce

  1. Initialize the handler with PAT and org url
  2. Provide payload to the getCommitDiffs method as above
@DmitriiBobreshev
Copy link
Contributor

Hi @Om4n3k, thanks for the feedback, the GitApi is fully generated so we can't patch them by hand now. We'll try to fix it once we'll have enough time

Copy link

This issue has had no activity in 90 days. Please comment if it is not actually stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants