Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telephony] Alphanumeric Input code only supports English disambiguation #1401

Open
stevengum opened this issue Dec 5, 2022 · 0 comments
Open
Labels
bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. P1 Painful if we don't fix, won't block releasing

Comments

@stevengum
Copy link
Member

Describe the bug

    This is too fragile, and only works for English.

Originally posted by @arturl in #1389 (comment)

if (tokens[1].ToLowerInvariant() == "as" && tokens[2].ToLowerInvariant() == "in")

The SerialNumberInput node which supports alphanumeric input aggregation only supports English (e.g. listening for "as" or "in" and only supporting disambiguating '8' and 'A' at this time)

private static readonly Dictionary<char, char> AlphabetReplacementsTable = new Dictionary<char, char>
{
{ '8', 'A' }
};

Version

latest of Microsoft.Bot.Components.Telephony

Expected behavior

More languages than just English are supported or configurable by bot authors

@stevengum stevengum added P1 Painful if we don't fix, won't block releasing ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. bug Indicates an unexpected problem or an unintended behavior. labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. P1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

No branches or pull requests

1 participant