Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EM and WattTime Client Tests to use a real moq for httpClient message handling #237

Open
6 of 11 tasks
JenMadiedo opened this issue Jan 5, 2023 · 1 comment
Open
6 of 11 tasks

Update EM and WattTime Client Tests to use a real moq for httpClient message handling #237

JenMadiedo opened this issue Jan 5, 2023 · 1 comment
Assignees
@JenMadiedo
Labels
Needs Triage

Comments

@JenMadiedo
Copy link

JenMadiedo commented Jan 5, 2023 •
edited
Loading

Description

As a Carbon Aware application developer, I want a standard moq infrastructure for writing client tests.

See: Green-Software-Foundation#194 (comment)

Acceptance Criteria

  • Remove custom mocks of http class in client tests
  • Client tests use Moq.Protected and have clear path for replicating/adding more tests
  • Unit Tests are completed and code passes tests

Dependencies

Task List

  • Remove custom mock of http class in ElectricityMapsClientTest
  • Remove custom mock of http class in WattTimeClientTest
  • Use Moq.Protected to simulate Http Client

Sprint-Ready Checklist

  • Acceptance criteria defined
  • Acceptance criteria is verifiable / testable
  • External / 3rd Party dependencies identified
  • Engineering team understands acceptance criteria
  • Is the user story small enough to be implemented in a short amount of time, but large enough to provide value?
@JenMadiedo JenMadiedo self-assigned this Jan 5, 2023
@JenMadiedo
Copy link
Author

PR: Green-Software-Foundation#240

JenMadiedo pushed a commit that referenced this issue Jan 10, 2023
@vaughanknight
Merge pull request #237 from microsoft/219/CarbonAwareNullable
9f75054 
Enable "Nullable" for CarbonAware Project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JenMadiedo JenMadiedo

Labels
Needs Triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JenMadiedo