Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit test coverage + style #240

Open
8 of 14 tasks
JenMadiedo opened this issue Jan 11, 2023 · 1 comment
Open
8 of 14 tasks

Improve unit test coverage + style #240

JenMadiedo opened this issue Jan 11, 2023 · 1 comment
Assignees
@in4margaret @Kpopovs1 @JenMadiedo
Labels
maintainability Triage Approved

Comments

@JenMadiedo
Copy link

JenMadiedo commented Jan 11, 2023 •
edited by Kpopovs1
Loading

Description

As a Carbon Aware application developer, I want to know that all the existing codepaths have been unit tested to ensure bugs are caught

Acceptance Criteria

  • Ensure that all external client functions (WebAPi, CLI, and Library) are fully unit tested and code coverage confirms (ignoring non-testable code paths). Example of forecast/batch not having tests.
  • Ensure that the main aggregator and data source functions (which are part of a flow from the client) are fully unit tested and code coverage confirms (ignoring non-testable code paths)
  • Condense redundantly similar tests into single test with multiple test cases (exception throwing, null/edge cases are good ones usually)
  • Ensure complex functions have edge case testing too, not just happy path

Dependencies

Task List

  • Review WebApi tests
  • Review CLI tests
  • Review CA Library tests
  • Review Data Sources tests
  • Open draft PR

Sprint-Ready Checklist

  • Acceptance criteria defined
  • Acceptance criteria is verifiable / testable
  • External / 3rd Party dependencies identified
  • Engineering team understands acceptance criteria
  • Is the user story small enough to be implemented in a short amount of time, but large enough to provide value?
@JenMadiedo JenMadiedo changed the title Improve unit test coverage Improve unit test coverage + style Jan 11, 2023
@juzuluag
Copy link

PR Green-Software-Foundation#298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@in4margaret in4margaret

@Kpopovs1 Kpopovs1

@JenMadiedo JenMadiedo

Labels
maintainability Triage Approved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gfmatthews @in4margaret @Kpopovs1 @juzuluag @JenMadiedo