Various version updates to bring project to using more current packages. (#1232)

* Version updates for:
1. AutoFixture 4.15.0->4.18.1
2. AutoFixture.Xunit2 4.15.0->4.18.1
3. Microsoft.Build.Utilities.Core 16.4.0->17.8.3
4. Microsoft.CodeAnalysis.CSharp.CodeStyle 4.4.0->4.8.0
5. Microsoft.CodeAnalysis.NetAnalyzers 8.0.0-preview1.23124.1 -> 8.0.0

And updates to satisfy CodeAnalysis updates:
1. Microsoft.Diagnostics.Runtime.GetInterface marked static. (no instance access)
2. move a string.indexof usage to string.contains for readability.

* Removed updates to Microsoft.CodeAnalysis.CSharp.CodeStyle and Microsoft.CodeAnalysis.Netanalyzers versions.

---------

Co-authored-by: Scott Wadsworth <bwadswor@microsoft.com>

Author: bwadswor

src/Microsoft.Diagnostics.Runtime.Tests/Microsoft.Diagnostics.Runtime.Tests.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFrameworks>net6.0</TargetFrameworks>
@@ -29,8 +29,8 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="AutoFixture" Version="4.15.0" />
-    <PackageReference Include="AutoFixture.Xunit2" Version="4.15.0" />
+    <PackageReference Include="AutoFixture" Version="4.18.1" />
+    <PackageReference Include="AutoFixture.Xunit2" Version="4.18.1" />
     <PackageReference Include="NETStandard.Library" Version="2.0.3" />
   </ItemGroup>
 

src/Microsoft.Diagnostics.Runtime/ClrType.cs

@@ -136,7 +136,7 @@ public IEnumerable<ClrInterface> EnumerateInterfaces()
             }
         }
 
-        private ClrInterface? GetInterface(IAbstractMetadataReader import, int mdIFace)
+        private static ClrInterface? GetInterface(IAbstractMetadataReader import, int mdIFace)
         {
             ClrInterface? result = null;
             string? name;

src/Microsoft.Diagnostics.Runtime/Extensions/SpanExtensions.cs

@@ -85,7 +85,7 @@ public static unsafe uint AsUInt32(this Span<byte> span, int offset = 0)
 #if !NETCOREAPP3_1
         public static bool Contains(this string source, string value, StringComparison comparisonType)
         {
-            return source.IndexOf(value, comparisonType) != -1;
+            return source.Contains(value, comparisonType);
         }
 #endif
     }

src/TestTasks/TestTasks.csproj

@@ -1,11 +1,11 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFrameworks>net6.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Build.Utilities.Core" Version="16.4.0" />
+    <PackageReference Include="Microsoft.Build.Utilities.Core" Version="17.8.3" />
   </ItemGroup>
 
   <ItemGroup>