Fixes generating OpenAPI specs with duplicate response headers. Closes #571 (#581)

waldekmastykarz · web-flow · commit 5b94e84ca7f6 · 2024-02-23T14:32:25.000+01:00
diff --git a/dev-proxy-plugins/RequestLogs/OpenApiSpecGeneratorPlugin.cs b/dev-proxy-plugins/RequestLogs/OpenApiSpecGeneratorPlugin.cs
@@ -583,6 +583,12 @@ private void SetResponseFromSession(OpenApiOperation operation, Response respons
                     continue;
                 }
 
+                if (openApiResponse.Headers.ContainsKey(header.Name))
+                {
+                    _logger?.LogDebug("    Header {headerName} already exists in response", header.Name);
+                    continue;
+                }
+
                 openApiResponse.Headers.Add(header.Name, new OpenApiHeader
                 {
                     Schema = new OpenApiSchema { Type = "string" }

Original file line number	Diff line number	Diff line change
`@@ -583,6 +583,12 @@ private void SetResponseFromSession(OpenApiOperation operation, Response respons`
`583`	`583`	`continue;`
`584`	`584`	`}`
`585`	`585`
	`586`	`+ if (openApiResponse.Headers.ContainsKey(header.Name))`
	`587`	`+ {`
	`588`	`+ _logger?.LogDebug(" Header {headerName} already exists in response", header.Name);`
	`589`	`+ continue;`
	`590`	`+ }`
	`591`	`+`
`586`	`592`	`openApiResponse.Headers.Add(header.Name, new OpenApiHeader`
`587`	`593`	`{`
`588`	`594`	`Schema = new OpenApiSchema { Type = "string" }`