From 3c58a6c16a644178324c7b70b7a9214b56fc0d66 Mon Sep 17 00:00:00 2001 From: Darren Hoehna Date: Fri, 26 Apr 2024 11:58:57 -0700 Subject: [PATCH 1/5] Cloning submodules (#384) Co-authored-by: Darren Hoehna --- src/GitHubExtension/Providers/RepositoryProvider.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/GitHubExtension/Providers/RepositoryProvider.cs b/src/GitHubExtension/Providers/RepositoryProvider.cs index 8b85fa6..df40dd7 100644 --- a/src/GitHubExtension/Providers/RepositoryProvider.cs +++ b/src/GitHubExtension/Providers/RepositoryProvider.cs @@ -222,6 +222,7 @@ public IAsyncOperation CloneRepositoryAsync(IRepository var cloneOptions = new LibGit2Sharp.CloneOptions { Checkout = true, + RecurseSubmodules = true, }; if (developerId != null) From 21826afe4fe0692f2ca7cc2711a1acb10521a86c Mon Sep 17 00:00:00 2001 From: Darren Hoehna Date: Fri, 26 Apr 2024 12:00:35 -0700 Subject: [PATCH 2/5] Returning exception message for more general exceptions. (#386) * Adding 'Please check the logs' * SHowing the error on the loading screen --------- Co-authored-by: Darren Hoehna --- src/GitHubExtension/Providers/RepositoryProvider.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/GitHubExtension/Providers/RepositoryProvider.cs b/src/GitHubExtension/Providers/RepositoryProvider.cs index df40dd7..8598b8b 100644 --- a/src/GitHubExtension/Providers/RepositoryProvider.cs +++ b/src/GitHubExtension/Providers/RepositoryProvider.cs @@ -268,12 +268,12 @@ public IAsyncOperation CloneRepositoryAsync(IRepository catch (LibGit2Sharp.LibGit2SharpException libGitTwoException) { Log.Error(libGitTwoException, $"Either no logged in account has access to this repository, or the repository can't be found."); - return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, "LibGit2 library threw an exception.", "LibGit2 library threw an exception."); + return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, libGitTwoException.Message, libGitTwoException.Message); } catch (Exception e) { Log.Error(e, "Could not clone the repository."); - return new ProviderOperationResult(ProviderOperationStatus.Failure, e, "Something happened when cloning the repository.", "Something happened when cloning the repository."); + return new ProviderOperationResult(ProviderOperationStatus.Failure, e, e.Message, e.Message); } return new ProviderOperationResult(ProviderOperationStatus.Success, new ArgumentException("Nothing wrong"), "Nothing wrong", "Nothing wrong"); From 7ff2312db36ff5129806cabbb32a59a45cc56a2a Mon Sep 17 00:00:00 2001 From: Eric Johnson Date: Thu, 9 May 2024 15:21:48 -0700 Subject: [PATCH 3/5] Update version to 0.14 (#388) --- build/azure-pipelines.yml | 2 +- build/scripts/CreateBuildInfo.ps1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build/azure-pipelines.yml b/build/azure-pipelines.yml index d5c8b0a..7adba30 100644 --- a/build/azure-pipelines.yml +++ b/build/azure-pipelines.yml @@ -20,7 +20,7 @@ parameters: - release variables: - MSIXVersion: '0.1300' + MSIXVersion: '0.1400' solution: '**/GitHubExtension.sln' appxPackageDir: 'AppxPackages' testOutputArtifactDir: 'TestResults' diff --git a/build/scripts/CreateBuildInfo.ps1 b/build/scripts/CreateBuildInfo.ps1 index 7481b1f..de6a73b 100644 --- a/build/scripts/CreateBuildInfo.ps1 +++ b/build/scripts/CreateBuildInfo.ps1 @@ -5,7 +5,7 @@ Param( ) $Major = "0" -$Minor = "13" +$Minor = "14" $Patch = "99" # default to 99 for local builds $versionSplit = $Version.Split("."); From d11919aa96d2c6463c2f130b215437f120379676 Mon Sep 17 00:00:00 2001 From: Eric Johnson Date: Tue, 14 May 2024 11:16:30 -0700 Subject: [PATCH 4/5] Updating tdbuild to version 3 (#390) --- build/azure-pipelines.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/build/azure-pipelines.yml b/build/azure-pipelines.yml index 7adba30..c00faf0 100644 --- a/build/azure-pipelines.yml +++ b/build/azure-pipelines.yml @@ -83,13 +83,13 @@ extends: nugetConfigPath: 'nuget.config' externalFeedCredentials: 'DevHomeInternal' - - task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@1 + - task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@3 displayName: Send and Download Localization Files for Artifacts condition: and(eq(variables['EnableLocalization'], 'true'), eq(variables['UpdateLocalization'], 'true')) inputs: teamId: 71221 - authId: $(TouchdownAppId) - authKey: $(TouchdownAppKey) + TDBuildServiceConnection: $(TouchdownServiceConnection) + authType: SubjectNameIssuer resourceFilePath: | **\en-US\*.resw;P:466 **\en-US\PDP.xml @@ -98,14 +98,14 @@ extends: appendRelativeDir: true pseudoSetting: Included - - task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@1 + - task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@3 displayName: Download and Use Localization Files condition: eq(variables['EnableLocalization'], 'true') retryCountOnTaskFailure: 2 inputs: teamId: 71221 - authId: $(TouchdownAppId) - authKey: $(TouchdownAppKey) + TDBuildServiceConnection: $(TouchdownServiceConnection) + authType: SubjectNameIssuer resourceFilePath: | **\en-US\*.resw;P:466 **\en-US\PDP.xml @@ -365,14 +365,14 @@ extends: artifactName: MsixBundle_Release targetPath: StorePublish - - task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@1 + - task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@3 displayName: Download and Use Localization Files condition: eq(variables['EnableLocalization'], 'true') retryCountOnTaskFailure: 2 inputs: teamId: 71221 - authId: $(TouchdownAppId) - authKey: $(TouchdownAppKey) + TDBuildServiceConnection: $(TouchdownServiceConnection) + authType: SubjectNameIssuer resourceFilePath: | **\en-US\PDP.xml localizationTarget: false From 78219086a7ca6a1e8a4787a31094c8125fd19756 Mon Sep 17 00:00:00 2001 From: Felipe G Date: Tue, 14 May 2024 22:20:57 -0700 Subject: [PATCH 5/5] Saving the data (#391) Co-authored-by: Felipe da Conceicao Guimaraes --- src/GitHubExtension/Widgets/GitHubWidget.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/GitHubExtension/Widgets/GitHubWidget.cs b/src/GitHubExtension/Widgets/GitHubWidget.cs index 98d06f7..df7c7a2 100644 --- a/src/GitHubExtension/Widgets/GitHubWidget.cs +++ b/src/GitHubExtension/Widgets/GitHubWidget.cs @@ -130,6 +130,8 @@ public override void OnActionInvoked(WidgetActionInvokedArgs actionInvokedArgs) // It might take some time to get the new data, so // set data state to "unknown" so that loading page is shown. DataState = WidgetDataState.Unknown; + + ConfigurationData = actionInvokedArgs.Data; UpdateWidget(); SavedConfigurationData = string.Empty;