Skip to content

Commit 298df8b

Browse files
author
Anush
committed
Merge branch 'master' of https://github.com/microsoft/fluentui into usr/agupta/v9/fixDoublePaddingIssue
2 parents a4055b1 + 6d57e57 commit 298df8b

21 files changed

+87
-31
lines changed

apps/vr-tests/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"lint": "just-scripts lint",
1212
"start": "storybook dev -p 3000",
1313
"type-check": "tsc -p . --noEmit --baseUrl .",
14-
"test-vr": "storywright --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true --stepsApi parameters"
14+
"test-vr": "storywright --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true --stepsApi parameters --bailOnStoriesError"
1515
},
1616
"devDependencies": {
1717
"@fluentui/eslint-plugin": "*",

apps/vr-tests/src/stories/ComboBox.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export default {
5050
.snapshot('hover', { cropTo: '.testWrapper' })
5151
.click('.ms-Button-flexContainer')
5252
.hover('.ms-Button-flexContainer')
53-
.snapshot('click', { cropTo: '.ms-Layer' }) // Dropdown extends beyond testWrapper
53+
.snapshot('click') // Dropdown extends beyond testWrapper
5454
.end(),
5555
},
5656
} satisfies StoryParameters,

apps/vr-tests/src/stories/ContextutalMenu/ContextualMenu.stories.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,12 +243,12 @@ export default {
243243
parameters: {
244244
storyWright: {
245245
steps: new Steps()
246-
.snapshot('default', { cropTo: '.ms-Layer' })
246+
.snapshot('default')
247247
.hover('.ms-ContextualMenu-linkContent')
248-
.snapshot('hover', { cropTo: '.ms-Layer' })
248+
.snapshot('hover')
249249
.click('.ms-ContextualMenu-linkContent')
250250
.hover('.ms-ContextualMenu-linkContent')
251-
.snapshot('click', { cropTo: '.ms-Layer' })
251+
.snapshot('click')
252252
.end(),
253253
},
254254
} satisfies StoryParameters,

apps/vr-tests/src/stories/ContextutalMenu/ContextualMenuSubmenus.stories.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,13 @@ export default {
5656
storyWright: {
5757
steps: new Steps()
5858
.click('#button')
59-
.snapshot('menu opened', { cropTo: '.ms-Layer' })
59+
.snapshot('menu opened')
6060
.hover('#parent')
61-
.snapshot('parent hovered', { cropTo: '.ms-Layer' })
61+
.snapshot('parent hovered')
6262
.hover('#item1')
63-
.snapshot('item1 hovered', { cropTo: '.ms-Layer' })
63+
.snapshot('item1 hovered')
6464
.hover('#item2')
65-
.snapshot('item2 hovered', { cropTo: '.ms-Layer' })
65+
.snapshot('item2 hovered')
6666
.end(),
6767
},
6868
} satisfies StoryParameters,

apps/vr-tests/src/stories/DatePicker/DatePicker.stories.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ export default {
3939
.snapshot('hover datepicker', { cropTo: '.testWrapper' })
4040
.click('.ms-DatePicker')
4141
.hover('.ms-DatePicker')
42-
.snapshot('click', { cropTo: '.ms-Layer' })
42+
.snapshot('click')
4343
.hover(daySelector)
44-
.snapshot('hover day', { cropTo: '.ms-Layer' })
44+
.snapshot('hover day')
4545
.hover(monthSelector)
46-
.snapshot('hover month', { cropTo: '.ms-Layer' })
46+
.snapshot('hover month')
4747
.end(),
4848
},
4949
} satisfies StoryParameters,

apps/vr-tests/src/stories/DatePicker/DatePickerDisabled.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export default {
3737
.snapshot('hover datepicker', { cropTo: '.testWrapper' })
3838
.click('.ms-DatePicker')
3939
.hover('.ms-DatePicker')
40-
.snapshot('click', { cropTo: '.ms-Layer' })
40+
.snapshot('click')
4141
.end(),
4242
},
4343
} satisfies StoryParameters,

apps/vr-tests/src/stories/DatePicker/DatePickerNoMonthOption.stories.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ export default {
3838
.snapshot('hover datepicker', { cropTo: '.testWrapper' })
3939
.click('.ms-DatePicker')
4040
.hover('.ms-DatePicker')
41-
.snapshot('click', { cropTo: '.ms-Layer' })
41+
.snapshot('click')
4242
.hover(daySelector)
43-
.snapshot('hover day', { cropTo: '.ms-Layer' })
43+
.snapshot('hover day')
4444
.end(),
4545
},
4646
} satisfies StoryParameters,

apps/vr-tests/src/stories/Dropdown/Dropdown.stories.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ export default {
2323
.snapshot('hover', { cropTo: '.testWrapper' })
2424
.click('.ms-Dropdown')
2525
.hover('.ms-Dropdown')
26-
.snapshot('click', { cropTo: '.ms-Layer' })
26+
.snapshot('click')
2727
.hover('.ms-Dropdown-item')
28-
.snapshot('hover item', { cropTo: '.ms-Layer' })
28+
.snapshot('hover item')
2929
.end(),
3030
},
3131
} satisfies StoryParameters,

apps/vr-tests/src/stories/Dropdown/DropdownDisabled.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export default {
1717
.snapshot('hover', { cropTo: '.testWrapper' })
1818
.click('.ms-Dropdown')
1919
.hover('.ms-Dropdown')
20-
.snapshot('click', { cropTo: '.ms-Layer' })
20+
.snapshot('click')
2121
.end(),
2222
},
2323
} satisfies StoryParameters,

apps/vr-tests/src/stories/HoverCard.stories.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ export default {
2828
storyWright: {
2929
steps: new Steps()
3030
.snapshot('default', { cropTo: '.testWrapper' })
31-
.hover('.ms-HoverCard-content')
32-
.snapshot('hover', { cropTo: '.testWrapper' })
31+
.click('.ms-HoverCard-host')
32+
.snapshot('fully expanded with test content')
3333
.end(),
3434
},
3535
} satisfies StoryParameters,

0 commit comments

Comments
 (0)