-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update dropdown.template.ts #35536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update dropdown.template.ts #35536
Conversation
add part="control" to the dropdown template control div to allow for css override of the rendered shadow-root component
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
| <template | ||
| @click="${(x, c) => x.clickHandler(c.event as PointerEvent)}" | ||
| @focusout="${(x, c) => x.focusoutHandler(c.event as FocusEvent)}" | ||
| @keydown="${(x, c) => x.keydownHandler(c.event as KeyboardEvent)}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-web-components/Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Avatar. - Dark Mode.normal.chromium.png | 10380 | Changed |
vr-tests-web-components/Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 443 | Changed |
vr-tests-web-components/RadioGroup 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/RadioGroup. - Dark Mode.2nd selected.chromium_3.png | 119 | Changed |
vr-tests-web-components/TextInput 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/TextInput. - Dark Mode.normal.chromium_1.png | 288 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
|
@andrewcolombi please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
add part="control" to the dropdown template control div to allow for css override of the rendered shadow-root component
Previous Behavior
fluent-dropdown rendered template has no part tag:
New Behavior
fluent-dropdown rendered template has part tag control:
Related Issue(s)