Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiota should warn the user when re-generating that all changes did manually by them will be overridden #5303

Open
maisarissi opened this issue Sep 2, 2024 · 0 comments
Labels
status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request vscode-extension Work related to the vscode-extension

Comments

@maisarissi
Copy link
Contributor

maisarissi commented Sep 2, 2024

Sometimes users find points of improvements in the Kiota generated files, for both client and plugin generation.
For example, Kiota might have an issue in the deserialization logic, and the user decided to fix it manually in the generated code. Or when creating a plugin, the user might update the generated plugin to add more conversation starters, or enhance the function descriptions so Copilot can be accurate when matching the functions.

When editing an existing plugin/client in the VS Code extension, and regenerating or when clicking on "re-generate" codelense in the manifest.json, the user should get an warn message saying all changes made manually to the generated files will be overriden.

image

Acceptance Criteria:
1 - When editing an existing client, when clicking on "Re-generate" button image, Kiota should warn the user all manual changes will be overridden.
2 - When using the codelense in the workspace.json file image, the user should also get the warning.
3 - The warning should be shown every time the user hits "Re-generate", both in the API Explorer button or in the codelense.
4 - The regeneration should only be done when the user hits on "Yes, override it".
5 - When the user hits on "Cancel" after getting the warning, Kiota shouldn't re-generate the client/plugin.

@maisarissi maisarissi added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels Sep 2, 2024
@fey101 fey101 added the vscode-extension Work related to the vscode-extension label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request vscode-extension Work related to the vscode-extension
Projects
Status: Needs Triage 🔍
Development

No branches or pull requests

2 participants