Avoid IComposedTypeWrapper for common base class?

[lvde0]

Is your feature request related to a problem? Please describe the problem.

Kiota generates IComposedTypeWrapper for oneof sets. This is fine when the types in the set don't share a common base schema ("inherited" via allof), but I think it would be much nicer to just generate the base class directly when they do?

Example:

 "animals": {
   "type": "array",
   "items": {
     "oneOf": [
       {
         "$ref": "#/components/schemas/Dog"
       },
       {
         "$ref": "#/components/schemas/Cat"
       },
       {
         "$ref": "#/components/schemas/Mouse"
       }
     ]
   }
 }

Ideally this should generate List<Animal> not List<IComposedTypeWrapper>. Is this possible somehow?

Client library/SDK language

Csharp

Describe the solution you'd like

Additional context

No response

[baywet]

HI @lvde0
Thank you for using kiota and for reaching out.

This approach would be making the assumption these member types somehow have something in common (besides being used at the same place), which is not always true (depends on the API design).

What limitations are you facing here?

[lvde0]

@baywet Yes, it might not always be the case. But I am proposing that when the types share the same "base type" we could simply return a list of base type instead of IComposedTypeWrapper. It's not critical, but it would be a nice QOL addition IMO.

[baywet]

Thank you for the additional information.

The challenge with this approach is that it might not work in all cases. Especially if types are used different places like a union type at one place and an inheritance hierarchy at another. Making that change would translate in serialization/deserialization issues.

Let us know if you have any additional comments or questions.

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.