Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add ability to tag an item as exported or not. #1046

Open
alanz opened this issue Jul 22, 2020 · 5 comments
Open

feature request: add ability to tag an item as exported or not. #1046

alanz opened this issue Jul 22, 2020 · 5 comments
Labels
document symbols feature-request Request for new features or functionality
Milestone

Comments

@alanz
Copy link

alanz commented Jul 22, 2020

This would probably involve extending the SemanticTokenModifiers to include an exported enum value, but ideally should reflect in the hierarchy view too.

This allows the kind of effect shown in this snapshot of a competing IDE, where the lock/unlock symbol is shown based on whether the function is exported or not.

Screenshot 2020-07-22 at 12 38 46

@kjeremy
Copy link
Contributor

kjeremy commented Jul 22, 2020

In the screenshot it looks more like this should be exposed as a SymbolTag

@alanz
Copy link
Author

alanz commented Jul 22, 2020

In the screenshot it looks more like this should be exposed as a SymbolTag

That is what I thought too, but they are new, and the only value currently is Deprecated. I was not sure if this was the right use-case for them.

@dbaeumer
Copy link
Member

I agree that this has to go as a symbol tag.

@dbaeumer dbaeumer added feature-request Request for new features or functionality document symbols labels Nov 11, 2020
@dbaeumer dbaeumer added this to the Backlog milestone Nov 11, 2020
@beyang
Copy link

beyang commented Feb 24, 2021

This seems related to (might be a duplicate of) #98

@dbaeumer
Copy link
Member

dbaeumer commented Mar 1, 2021

@beyang thanks for pointing to #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document symbols feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants