[Bug] 0.34.0 linkProvider does not provide links

[yanny7]

Reproducible in vscode.dev or in VS Code Desktop?

• Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

• Not reproducible in the monaco editor playground

Monaco Editor Playground Code

var editor = monaco.editor.create(document.getElementById('container'), {
	value: '{\n\t"dependencies": {\n\t\t\n\t}\n}\n',
	language: 'json'
});

var commandId = editor.addCommand(
	0,
	function () {
		// services available in `ctx`
		alert('my command is executing!');
	},
	''
);

monaco.languages.registerLinkProvider('json', {
    provideLinks: function(model, token) {
        return [
            {range: {startLineNumber: 2, startColumn: 4, endLineNumber: 2, endColumn: 15},
            url: model.uri, tooltip: "Hello"}
        ]
    }
});

Reproduction Steps

1. just execute script above

Actual (Problematic) Behavior

no link provided for line 2

Expected Behavior

link is provided for line 2

Additional Context

No response

[tamayika]

Your code is a bit wrong.
You must return {links: [...]}

var editor = monaco.editor.create(document.getElementById('container'), {
    value: '{\n\t"dependencies": {\n\t\t\n\t}\n}\n',
    language: 'json'
});

monaco.languages.registerLinkProvider('json', {
    provideLinks: function(model, token) {
        return {
            links: [
               {range: {startLineNumber: 2, startColumn: 4, endLineNumber: 2, endColumn: 15},
                url: model.uri, tooltip: "Hello"}
            ]
        };
    }
});