Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Step does not work on initial breakpoint of module load breakpoint in windbg #10

Closed
1 task done
cfernald opened this issue Apr 11, 2024 · 2 comments
Closed
1 task done

[Bug]: Step does not work on initial breakpoint of module load breakpoint in windbg #10

cfernald opened this issue Apr 11, 2024 · 2 comments
Assignees
@cfernald
Labels
type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@cfernald
Copy link
Contributor

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

When stepping on any CPU breakpoint instruction, the PC does not progress. Instead, you have to progress with a continue to a breakpoint. This is inconvenient and breaks with intuition.

Expected Behavior

Single step should work from a CPU breakpoint instruction.

Steps To Reproduce

Break on initial breakpoint.
step

Build Environment

- OS(s): N/A
- Tool Chain(s): N/A
- Targets Impacted: N/A

Version Information

Version 0.1.0

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response
@cfernald cfernald added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Apr 11, 2024
@github-actions github-actions bot added the urgency:medium Important with a moderate impact label Apr 11, 2024
@cfernald cfernald removed the state:needs-triage Needs to triaged to determine next steps label Apr 11, 2024
@cfernald cfernald mentioned this issue Apr 25, 2024
Merged
5 tasks
cfernald added a commit that referenced this issue Apr 25, 2024
@cfernald
Improvements to Windbgx integration and UEFI extension (#22)
8b30829 
## Description

Improvements to the core for:
1. Add windbg workaround PCD to allow disabling for native GDB systems.
2. Add break reason for debugger initiated breakpoints
3. Add workaround for #10 
4. Fix `.reboot` not working

Improvements to UEFI Extension:
1. Cleaned up help function
2. Added crude implementation for adv logger parser 


- [x] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [x] Includes documentation?

## How This Was Tested

Local tests on QEMU

## Integration Instructions

N/A
@cfernald
Copy link
Contributor Author

I worked around this, the real fix went in with #23 but this will require an update from windbgx in microsoft/WinDbg-Samples#108 before the workaround can be removed.

Leaving this open until the work-around can be removed.

@cfernald cfernald mentioned this issue May 6, 2024
Merged
5 tasks
@cfernald
Copy link
Contributor Author

cfernald commented May 6, 2024

Fixed in windbgx version 1.2405.3001.0.

@cfernald cfernald closed this as completed May 6, 2024
cfernald added a commit that referenced this issue May 6, 2024
@cfernald
Remove windbg breakpoint workaround & improvements (#25)
6f04dea 
## Description

1. Remove workaround where windbgx wasn't able to step when broken on
debug breakpoints for #10. This is fixed in windbgx version
1.2405.3001.0
2. Minor improvements to the info monitor command.

- [x] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Tested locally with Q35

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfernald cfernald

Labels
type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cfernald