Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Supervised Standalone MM Implementation #59

Closed
os-d opened this issue Sep 13, 2024 · 2 comments
Closed

[Feature]: Supervised Standalone MM Implementation #59

os-d opened this issue Sep 13, 2024 · 2 comments
Labels
state:needs-owner Needs an issue owner to be assigned state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:feature-request A new feature proposal urgency:high Significant with a critical impact

Comments

@os-d
Copy link
Contributor

os-d commented Sep 13, 2024

Feature Overview

Currently, mu_feature_debugger does not support debugging supervised StMM.

Solution Overview

Support debugging in this environment.

Alternatives Considered

No response

Urgency

High

Are you going to implement the feature request?

Someone else needs to implement the feature

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@os-d os-d added type:feature-request A new feature proposal state:needs-triage Needs to triaged to determine next steps labels Sep 13, 2024
@github-actions github-actions bot added urgency:high Significant with a critical impact state:needs-owner Needs an issue owner to be assigned labels Sep 13, 2024
os-d added a commit to microsoft/mu_tiano_platforms that referenced this issue Oct 2, 2024
## Description

This PR turns mu_feature_debugger on by default in Q35/SBSA. It sets no
initial breakpoint, but will break in on an exception. As part of this,
QemuRunner defaults to having `SERIAL_PORT=50001` if this is not
overridden, so that on a regular boot of Q35 the debugger can easily be
used. On SBSA, the serial port is not added by default, as it will
prevent writing to stdout, making it hard to tell progress.

An additional command line flag is added `BLD_*_DXE_DBG_BRK` to control
whether the initial breakpoint is set. Passing `BLD_*_DXE_DBG_BRK=TRUE`
on the commandline will set an unlimited initial breakpoint on DxeCore
entrance.

The other caveat in SBSA is that with a single serial port, debugger
polling is disabled, otherwise the debugger can eat user keystrokes at
the shell.

Once supervised StMM support is added to mu_feature_debugger
(microsoft/mu_feature_debugger#59), it will be
added here with a corresponding flag to force breaking in to the MM
debugger.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Tested by booting Q35 with no exceptions, with an exception and breaking
in, and with the force flag and breaking in on initial breakpoint.

## Integration Instructions

See above.
Copy link

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Oct 28, 2024
Copy link

github-actions bot commented Nov 4, 2024

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-owner Needs an issue owner to be assigned state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:feature-request A new feature proposal urgency:high Significant with a critical impact
Projects
None yet
Development

No branches or pull requests

1 participant