Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Feature request for rush build's output folder to be based on an environment variable #4938

Open
timmydo opened this issue Sep 23, 2024 · 1 comment

Comments

@timmydo
Copy link

timmydo commented Sep 23, 2024

Summary

Our git repository currently uses a msbuild-based build system. We invoke rush build to build ~80 packages from our rush.json. Currently these packages drop files into the dist directory in each projectFolder. (Later we copy them out to another location). We are migrating our normal build process to use an artifacts output layout (https://learn.microsoft.com/en-us/dotnet/core/sdk/artifacts-output) which puts all the build artifacts in a separate root folder instead of in the source code folders. We would like to migrate our rush build to also put build artifacts in $RUSH_BASE_OUTPUT_DIRECTORY/$RUSH_PROJECT_NAME/dist or similar.

Repro steps

projectOutputFolderNames from https://rushjs.io/pages/maintainer/build_cache/ to support environment variables. Basically, I think we can pass environment variables today and edit package.json to put files in the right place, but we need the cache to support such a feature or rebuilds will be painful.

@github-project-automation github-project-automation bot moved this to Needs triage in Bug Triage Sep 23, 2024
@iclanton iclanton moved this from Needs triage to General Discussions in Bug Triage Sep 30, 2024
@iclanton
Copy link
Member

This is an interesting proposal, that may be able to be supported with injected dependencies for downstream projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: General Discussions
Development

No branches or pull requests

2 participants