From a9a920a602213cfbda9a15c49ec4a409b4e464bc Mon Sep 17 00:00:00 2001 From: Sebastian Gomez <69322674+sebasgomez238@users.noreply.github.com> Date: Mon, 4 Dec 2023 13:58:52 -0500 Subject: [PATCH] Bump sdk, pin dependency versions. (#455) * Bump sdk, pin dependency version. * Bump to 8.0.0 * Add timer around package metadata parsing --------- Co-authored-by: Sebastian Gomez --- Directory.Packages.props | 3 ++- global.json | 2 +- src/Microsoft.Sbom.Api/Microsoft.Sbom.Api.csproj | 1 + .../PackageDetails/PackageDetailsFactory.cs | 8 ++++++-- src/Microsoft.Sbom.Api/Utils/Events.cs | 1 + 5 files changed, 11 insertions(+), 4 deletions(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index 68acb1a75..484813a93 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -7,7 +7,7 @@ - 4.0.6 + 4.0.8 @@ -21,6 +21,7 @@ + diff --git a/global.json b/global.json index a2a384b45..d07970ac2 100644 --- a/global.json +++ b/global.json @@ -1,6 +1,6 @@ { "sdk": { - "version": "8.0.100-rc.2.23502.2", + "version": "8.0.100", "rollForward": "latestMajor" } } diff --git a/src/Microsoft.Sbom.Api/Microsoft.Sbom.Api.csproj b/src/Microsoft.Sbom.Api/Microsoft.Sbom.Api.csproj index 76d696a54..a840a415f 100644 --- a/src/Microsoft.Sbom.Api/Microsoft.Sbom.Api.csproj +++ b/src/Microsoft.Sbom.Api/Microsoft.Sbom.Api.csproj @@ -16,6 +16,7 @@ + diff --git a/src/Microsoft.Sbom.Api/PackageDetails/PackageDetailsFactory.cs b/src/Microsoft.Sbom.Api/PackageDetails/PackageDetailsFactory.cs index 784237ea0..1c17e79c0 100644 --- a/src/Microsoft.Sbom.Api/PackageDetails/PackageDetailsFactory.cs +++ b/src/Microsoft.Sbom.Api/PackageDetails/PackageDetailsFactory.cs @@ -8,6 +8,7 @@ using Microsoft.ComponentDetection.Contracts.BcdeModels; using Microsoft.ComponentDetection.Contracts.TypedComponent; using Microsoft.Sbom.Api.Output.Telemetry; +using Microsoft.Sbom.Api.Utils; using Serilog; namespace Microsoft.Sbom.Api.PackageDetails; @@ -34,9 +35,12 @@ public PackageDetailsFactory(ILogger log, IRecorder recorder, IPackageManagerUti public IDictionary<(string Name, string Version), PackageDetails> GetPackageDetailsDictionary(IEnumerable scannedComponents) { - var packageDetailsLocations = GetPackageDetailsLocations(scannedComponents); + using (recorder.TraceEvent(Events.SBOMParseMetadata)) + { + var packageDetailsLocations = GetPackageDetailsLocations(scannedComponents); - return ExtractPackageDetailsFromFiles(packageDetailsLocations); + return ExtractPackageDetailsFromFiles(packageDetailsLocations); + } } private List GetPackageDetailsLocations(IEnumerable scannedComponents) diff --git a/src/Microsoft.Sbom.Api/Utils/Events.cs b/src/Microsoft.Sbom.Api/Utils/Events.cs index e2a35160e..84d370d33 100644 --- a/src/Microsoft.Sbom.Api/Utils/Events.cs +++ b/src/Microsoft.Sbom.Api/Utils/Events.cs @@ -7,6 +7,7 @@ internal static class Events { #region Generation internal const string SBOMGenerationWorkflow = "Total generation time"; + internal const string SBOMParseMetadata = "Total metadata parsing time"; internal const string FilesGeneration = "Files generation time"; internal const string PackagesGeneration = "Packages generation time"; internal const string RelationshipsGeneration = "Relationships generation time";