Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pane focus is lost after pane swap #18184

Open
kulkalkul opened this issue Nov 12, 2024 · 0 comments
Open

Pane focus is lost after pane swap #18184

kulkalkul opened this issue Nov 12, 2024 · 0 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@kulkalkul
Copy link

kulkalkul commented Nov 12, 2024

Windows Terminal version

1.21.2911.0

Windows build number

10.0.22631.0

Other Software

No response

Steps to reproduce

Create a split pane, use keybinds to swap between them.

Expected Behavior

Pane shouldn't lose focus.

Actual Behavior

Pane loses focus, Terminal doesn't respect any inputs unless the window itself is refocused, here is visual example. I was able to reproduce it with empty $PROFILE (video recording wasn't though):
https://github.com/user-attachments/assets/08cb98dc-72cc-4c23-962e-f909668c184c

Video description:

  • I swap panes twice, lose focus each time, click back to regain focus.
  • I change my active pane to show it works correctly without losing focus.
  • I alt-tab, swap pane again, same behavior.
  • I alt-tab immediately after losing focus, now swapping panes suddenly working without losing focus.
  • I change my active pane.
  • I swap, and now I lose the focus.
  • I do showcase that last one with alt-tab multiple times.

So my uneducated guess is there are two different focuses in play there, usual Windows window focus and Terminal's pane focus. So, clicking on terminal or changing panes via keybind affects pane focus state, which sets the state in a way to cause unexpected behavior. But alt-tabbing it after focus is lost sets that state in a different way (or doesn't set it at all), which allows behavior to work as expected until it is re-set back via clicking or pane change.

@kulkalkul kulkalkul added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

1 participant