Debugger completion inserted wrong

[felixfbecker]

• VSCode Version: 1.7.0-insider

Assuming we have these variables:

I'm typing $aBoo into the debug console and want to get completion to $aBoolean:

Notice how the $ is not highlighted.

The debug adapter responds correctly with:

targets: [
  { label: '$aBoolean', length: 9, start: 0, type: 'variable' }
]

As you can see it even specifies that the completion should be inserted at the beginning of the console.

After hitting enter:

$ is duplicated.

[isidorn]

October to investigate

[isidorn]

This bottomline issue is the definition of a word in php. Since the repl input is asking the editor model what is the word at a position, and the returned word does not contain the character $ which is wrong.

I believe the definition of a word can be changed in the php extension. Assigning to @mousetraps to investigate further. I think @aeschli can help if needed

[roblourens]

@felixfbecker Do you know if this is still an issue? I don't get completions from the PHP Debug extension, should I?

[felixfbecker]

Haven't tried in a long time, here's the PR: xdebug/vscode-php-debug#71

[roblourens]

Thanks. Now I see the correct highlighting. When I accept the completion, it doesn't insert the $. But in the debug adapter I see

I think 'text' shouldn't omit the $.