Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files to include containing non-trivial glob pattern seems to fails to display any valid match #229084

Closed
Kazimierzw-Google opened this issue Sep 19, 2024 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@Kazimierzw-Google
Copy link

Kazimierzw-Google commented Sep 19, 2024

Does this issue occur when all extensions are disabled?: Yes

Version: 1.93.1 (Universal)
Commit: 38c31bc
Date: 2024-09-11T17:20:05.685Z (1 wk ago)
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.6.0

Steps to Reproduce:

  1. Search regex arbitrary e.g. .*
  2. Files to include shall contain a non-trivial glob pattern e.g. ./chromeos/src/**.go
  3. No results. Expected all of them. When I rid of the **.go the results output started to populate immediately.

Also:

  1. I'd really like to have a regex pattern as a post-processing step on the path of found matches.
@andreamah
Copy link
Contributor

If you're looking for results in all .go files under ./chromeos/src/, please use ./chromeos/src/*.go. If you're looking for all .go files recursively under ./chromeos/src/, try ./chromeos/src/**/*.go.

I'd really like to have a regex pattern as a post-processing step on the path of found matches.

We prefer to match files using globs. Once our TextSearchProvider extension API gets finalized, you could make an extension that implements this feature (but you'll also need to re-implement the whole search provider).

@andreamah andreamah added the info-needed Issue requires more information from poster label Sep 23, 2024
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants