Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDP serving broken on master #1593

Closed
johanbrandhorst opened this issue Aug 13, 2024 · 1 comment
Closed

UDP serving broken on master #1593

johanbrandhorst opened this issue Aug 13, 2024 · 1 comment

Comments

@johanbrandhorst
Copy link
Contributor

As explained in #1589 (comment):

I think this change unfortunately interacts badly with the default read timeout used in UDP servers (not TCP servers, in my testing). The default read timeout is 2 seconds, and it seems that any UDP server started via ListenAndServe or ActivateAndServer dies after 2 seconds of no traffic. It seems the TCP server is staying open, not sure why. Presumably this was already happening before, but we were just automatically retrying the error and so it was hidden from us.
Is timing out UDP reads repeatedly while serving intentional? Digging around in the history, it seems the Temporary() check for UDP was introduced to fix a different bug (#621), but I don't see it acknowledged that this will cause us to loop endlessly (albeit not too busily).
Maybe we want to revert this until we have a better understanding of the impact, because on master right now any UDP servers just stop immediately once the ReadTimeout is hit.

@miekg
Copy link
Owner

miekg commented Aug 13, 2024

reverting that commit, see #1594

@miekg miekg closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants