-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using insecure deprecated Net::IMAP.new args #1587
base: master
Are you sure you want to change the base?
Conversation
This fixes the insecure `verify = false` argument that was previously unconfigurable. Now _any_ SSLContext params can be set on the IMAP connection. The original parameters have been undocumented since ~2007, will print deprecation warnings in the next release and will be removed in a year. Fixes mikel#1586.
How should this change be documented? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I think accepting ssl_context_params as value for As of branch
How about keeping the
As for the 'reach' of this secure-by-default-setting: I think the |
|
||
imap.starttls if settings[:enable_starttls] | ||
imap = Net::IMAP.new(settings[:address], port: settings[:port], ssl: ssl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a good opportunity to nilify the default port setting as net/imap has good defaults since forever.
This fixes the insecure
verify = false
argument that was previously unconfigurable. Now any SSLContext params can be set on the IMAP connection.The original parameters have been undocumented since ~2007, will print deprecation warnings in the next release and will be removed in a year.
Fixes #1586.