[FR] patial matching for domains?

[simonfossom]

1st of all, awesome work! love the app! 🎉

And a suggestion: partial domain match
Great example is wikipedia: so many subdomains and diff urls.
I'd like to have wikipeida.css so it applies to all domains that match that url.
Same for goole, amazon, etc etc.

[mikker]

I could see this be a feature some day. Can't say when.
I've so far just used symlinks, so make twitter.com.css, symlink x.com.css to it. Same could be done for da.wikipedia.org.js => wikipedia.org.js.

[simonfossom]

Perfect! Solved the problem.

but what do you think about this small change:

• change match patterns in the register function in both web-ext/ff/sw.js and web-ext/chrome/sw.js.

// replacing 
`const matches = [`*://${domain}/*`, `*://www.${domain}/*`];` 

// with stg like 
function domainToPattern(domain) { return domain.replace(/[.+?^${}()|[\]\\]/g, '\\$&').replace(/\\\*/g, '.*').replace(/\*/g, '*'); }
const pattern = domainToPattern(domain);
const matches = [`*://${pattern}/*`];

[mikker]

Not immediately convinced. Top-level and subdomains are different entities and if we do this, it'll instead be hard to avoid subdomains matching top level.