From 6f11ca139f90f73ec62a64640b8189788d79bbcc Mon Sep 17 00:00:00 2001 From: Facu Spagnuolo Date: Wed, 25 Sep 2024 09:29:44 -0300 Subject: [PATCH] tasks: avoid magic numbers --- packages/tasks/contracts/bridge/HopBridger.sol | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/tasks/contracts/bridge/HopBridger.sol b/packages/tasks/contracts/bridge/HopBridger.sol index 993d238..f350f06 100644 --- a/packages/tasks/contracts/bridge/HopBridger.sol +++ b/packages/tasks/contracts/bridge/HopBridger.sol @@ -27,6 +27,9 @@ import '../interfaces/bridge/IHopBridger.sol'; contract HopBridger is IHopBridger, BaseBridgeTask { using FixedPoint for uint256; + // Ethereum mainnet chain ID = 1 + uint256 private constant MAINNET_CHAIN_ID = 1; + // Execution type for relayers bytes32 public constant override EXECUTION_TYPE = keccak256('HOP_BRIDGER'); @@ -138,7 +141,7 @@ contract HopBridger is IHopBridger, BaseBridgeTask { minAmountOut, recipient, tokenHopEntrypoint[token], - destinationChain == 1 ? 0 : (block.timestamp + maxDeadline), + destinationChain == MAINNET_CHAIN_ID ? 0 : (block.timestamp + maxDeadline), relayer, fee );