How to pass pathspec to consult-git-grep?

[iostapyshyn]

Hello,

BREAKING CHANGE: The syntax to pass options to consult-ripgrep, consult-fd etc. has changed. The overall syntax should be familiar since it resembles the usual shell syntax. The input after a dash is treated as options. In order to search for a token starting with a dash, escape the dash with a backslash. Input after two standalone dashes is treated as search pattern.

with this recent change in 3.3 regarding grep options, the ability to pass the pathspec argument to consult-git-grep like before #hello -- :!*.txt (search hello in all non-txt files) seems to have been lost due to special treatment of double dash. However, using the prefix argument (C-u M-x consult-git-grep RET) seems to still work.

Is there a nonobvious way to pass pathspec directly in the prompt like before?

[minad]

Why is the ability lost? cc @jdtsmith

[jdtsmith]

I think the problem is if -- is meaningful for the command itself effectively as a non-standard part of the options, but consult always recognizes it as "end of search term, now begin arguments".

Maybe consult--command-split should trust the user a bit more when -- is used. E.g.:

(consult--command-split "abc -- defun") ;; assume abc is an option, even though it doesn't start with `-'
(consult--command-split "-- *.txt -- defun") ;; assume `-- *.txt' is an option, since it's before the final `--'

I.e. alter it to mean "Input after the final two standalone dashes is treated as search pattern, with prior input the options".

[minad]

Yes, I think problems like this were the reason why I used the simplistic splitting method before.