From 9a759312be3de9ce50036632774aabc3a90501d0 Mon Sep 17 00:00:00 2001
From: Lars Heinrichs <lars.heinrichs@web.de>
Date: Mon, 12 Aug 2024 19:49:34 +0200
Subject: [PATCH] feat: add backwards compatibility with 'smoothed' option

---
 lib/chart/lineplot.ex           | 10 +++++++---
 lib/chart/svg.ex                |  4 ++++
 test/contex_line_chart_test.exs |  8 ++++++--
 3 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/lib/chart/lineplot.ex b/lib/chart/lineplot.ex
index 20dabc3..be59be9 100644
--- a/lib/chart/lineplot.ex
+++ b/lib/chart/lineplot.ex
@@ -51,7 +51,6 @@ defmodule Contex.LinePlot do
     custom_y_formatter: nil,
     width: 100,
     height: 100,
-    plot_style: :smooth,
     stroke_width: "2",
     colour_palette: :default
   ]
@@ -108,6 +107,8 @@ defmodule Contex.LinePlot do
 
     - `:plot_style` : :direct (default), :smooth or :step
 
+  For backwards compatibility, the option :smoothed was kept and is translated: true -> :smooth and false -> :direct.
+
   Note that the smoothing algorithm is a cardinal spline with tension = 0.3.
   You may get strange effects (e.g. loops / backtracks) in certain circumstances, e.g.
   if the x-value spacing is very uneven. This alogorithm forces the smoothed line
@@ -254,7 +255,10 @@ defmodule Contex.LinePlot do
          y_accessor,
          colour
        ) do
-    style = get_option(plot, :plot_style)
+    # keep backwards compatibility with old `:smoothed` option
+    style = get_option(plot, :plot_style) |> IO.inspect(label: "style")
+    smoothed = get_option(plot, :smoothed) |> IO.inspect(label: "smoothed")
+    plot_style = if smoothed != nil, do: smoothed, else: style
     stroke_width = get_option(plot, :stroke_width)
 
     options = [
@@ -282,7 +286,7 @@ defmodule Contex.LinePlot do
       |> Enum.chunk_by(fn {_x, y} -> is_nil(y) end)
       |> Enum.filter(fn [{_x, y} | _] -> not is_nil(y) end)
 
-    Enum.map(points_list, fn points -> line(points, style, options) end)
+    Enum.map(points_list, fn points -> line(points, plot_style, options) end)
   end
 
   @doc false
diff --git a/lib/chart/svg.ex b/lib/chart/svg.ex
index a29cbf3..8f53fc6 100644
--- a/lib/chart/svg.ex
+++ b/lib/chart/svg.ex
@@ -85,6 +85,10 @@ defmodule Contex.SVG do
 
   defp path([], _), do: ""
 
+  defp path(points, nil), do: path(points, :smooth)
+  defp path(points, true), do: path(points, IO.inspect(:smooth))
+  defp path(points, false), do: path(points, IO.inspect(:direct))
+
   defp path(points, :direct) do
     Enum.reduce(points, :first, fn {x, y}, acc ->
       coord = ~s|#{x} #{y}|
diff --git a/test/contex_line_chart_test.exs b/test/contex_line_chart_test.exs
index a043d02..9812941 100644
--- a/test/contex_line_chart_test.exs
+++ b/test/contex_line_chart_test.exs
@@ -41,8 +41,12 @@ defmodule ContexLineChartTest do
       C330.6666666666667,237.5 388.3333333333333,60 404,20 "
       """
 
-      output = Contex.SVG.line(points, :smooth) |> IO.iodata_to_binary()
-      IO.inspect(output)
+      output_new = Contex.SVG.line(points, :smooth) |> IO.iodata_to_binary()
+      output_old = Contex.SVG.line(points, true) |> IO.iodata_to_binary()
+
+      assert output_new == output_old
+
+      IO.inspect(output_new)
     end
   end
 end