-
Notifications
You must be signed in to change notification settings - Fork 89
Add sam2 #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add sam2 #1426
Conversation
This file was automatically generated from src/transformers/models/sam2/modular_sam2.py. It contains the Sam2ImageProcessorFast class and related methods for image processing, including crop generation, mask filtering, and post-processing.
Add Sam2Processor class for image and point processing
Summary of ChangesHello @zyd-ustc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Segment Anything Model 2 (SAM2) into the MindOne project, providing a comprehensive set of components for image segmentation. It includes the full model architecture, a fast image processor, and a unified input processor, all meticulously adapted to function within the MindSpore framework. This integration aims to expand MindOne's capabilities in advanced computer vision tasks, particularly in robust and flexible image segmentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the SAM2 model, including its modeling, image processor, and processor components. My review has identified several critical issues that need to be addressed. These include an import typo, incorrect method names for nn.Cell subclasses (forward instead of construct), an AttributeError due to a missing self assignment, and the use of PyTorch-specific device keyword arguments in MindSpore tensor creation functions, which will lead to errors. Additionally, there's a medium-severity issue where a tensor type conversion has no effect. These issues suggest the code was ported from PyTorch but not fully adapted to MindSpore's API and may not have been tested. I recommend a thorough review for similar porting errors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
What does this PR do?
Adds
1.Sam2 model
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx