Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks without id #355

Open
never-failing opened this issue Aug 22, 2021 · 3 comments
Open

Permalinks without id #355

never-failing opened this issue Aug 22, 2021 · 3 comments
Labels
bug Improvement Issues about project improvement in already existed features.

Comments

@never-failing
Copy link

never-failing commented Aug 22, 2021

First, categories and ads don't work without the ID https://prnt.sc/1qeiqrs.
Secondly, the settings in the admin panel https://prnt.sc/1qeiobo disappear. You need a fix or hardcode the ID in the links or make it mandatory.

@patriksh
Copy link
Contributor

The ID is required because that's what used to actually fetch the category/ad data from the database.

We should add a check to make sure the ID param is included in the permalink though.

@never-failing
Copy link
Author

never-failing commented Aug 23, 2021

I understand correctly that friendly URLs will not exist without an ID
work? No changes in the code?

@never-failing never-failing changed the title Постоянные ссылки без id Permalinks without id Aug 23, 2021
@navjottomer
Copy link
Member

using id is faster for detection. I'll see what I can do when I'll get some time for this.

@navjottomer navjottomer added the Improvement Issues about project improvement in already existed features. label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Improvement Issues about project improvement in already existed features.
Projects
None yet
Development

No branches or pull requests

4 participants
@navjottomer @patriksh @never-failing and others