Skip to content

Volume buttons take you out of the game, if pressed with Shift or Control. #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rabaimorp opened this issue Jan 6, 2025 · 10 comments
Closed
Labels
bug Something isn't working

Comments

@rabaimorp
Copy link

Describe the bug
If I try to adjust my volume while holding shift or control it opens a useless window, puts the game into windowed mode, and takes the focus out of the game (to the useless window). This already caused me to die once while I was running in a cave and tried to adjust my volume, and it took me out of the game. The useless window is just a textbox saying "Please check your Keyboard Layout. No Fallback Implemented"

Also on the launcher page I have a "5 joysticks can not be used as Gamepad Input Open settings to configure them." banner. But I opened settings, and I'm not sure what am I supposed to change to make the warning go away.

To Reproduce
Steps to reproduce the behavior:

  1. Open the game on the latest supported version
  2. Press one of the volume buttons while holding shift or control
  3. See useless textbox that takes you out of the game

Expected behavior
It should adjust my volume normally like when it does when I'm not holding shift or control. Or if thats not possible (for some reason) at the very least just do nothing at all, but it definitely shouldn't take you out of the game.

Screenshots
If applicable, add screenshots to help explain your problem.
screenshot_2025-01-06_23-21-27
@
screenshot_2025-01-06_23-21-16

Desktop (please complete the following information):

  • OS: Arch Linux
  • Version: Latest AUR build
  • Installation Type: The AUR

Additional context
Add any other context about the problem here.

@rabaimorp rabaimorp added the bug Something isn't working label Jan 6, 2025
@ChristopherHX
Copy link
Member

Installation Type: The AUR

Please request to get a release build add c(xx)flag -DNDEBUG to turn this off.

@rabaimorp
Copy link
Author

Installation Type: The AUR

Please request to get a release build add c(xx)flag -DNDEBUG to turn this off.

I have no idea what do you mean. Is this an automated message?

@ChristopherHX
Copy link
Member

Is this an automated message?

No

Ask for Help on the AUR package chat, and provide a link to my answer.

I don't have access to AUR and cannot do anything

@ChristopherHX
Copy link
Member

This bug doesn't happen using https://flathub.org/apps/io.mrarm.mcpelauncher and is not a bug anymore

@rabaimorp
Copy link
Author

In that case I'll wait until the next update in case that fixes it. If not I'll make an aur account and ask. Don't close this issue until than.

@HurricanePootis
Copy link

@ChristopherHX Would this bug be related to a makeflag standard in Arch Linux?

CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions \
        -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security \
        -fstack-clash-protection -fcf-protection \
        -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer"
CXXFLAGS="$CFLAGS -Wp,-D_GLIBCXX_ASSERTIONS"
LDFLAGS="-Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now \
         -Wl,-z,pack-relative-relocs"
LTOFLAGS="-flto=auto"

@HurricanePootis
Copy link

I fixed it in the AUR package. You should close this now @ChristopherHX

@rabaimorp
Copy link
Author

I fixed it in the AUR package. You should close this now @ChristopherHX

Thank you so much for fixing it, after updating the package to the latest build it seems to have been fixed! However the version in the "About" tab still shows as "Unknown"

@ChristopherHX
Copy link
Member

However the version in the "About" tab still shows as "Unknown"

Those are set by CMake arguments.

See here for an example
https://github.com/flathub/io.mrarm.mcpelauncher/blob/188cddfd318c3c46fc182164a20fb17ddbabb393/io.mrarm.mcpelauncher.json#L165-L168

This process is not documented

@HurricanePootis
Copy link

Will do this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants