Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSM and CSM environment #8

Open
AFCMS opened this issue Mar 26, 2023 · 9 comments
Open

SSM and CSM environment #8

AFCMS opened this issue Mar 26, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@AFCMS
Copy link
Member

AFCMS commented Mar 26, 2023

Why?

Support of the SSM and CSM environment, with a common folder for the utilities that are the same in the two environments.

Basically to enable completion for SSM you will need to add both the path to the ssm folder and the common folder.

The documentation should be mostly complete for ssm before doing so

(dc7258d)

@AFCMS AFCMS added the enhancement New feature or request label Mar 26, 2023
@lua-rocks
Copy link
Member

I'm sorry for deleting this directory without asking. Maybe your extension won't work properly because of this, but let's make the full documentation first, and then you sort the files as needed.

@AFCMS
Copy link
Member Author

AFCMS commented Mar 26, 2023

Its fine, the extension is still far from complete anyways and I am a bit busy right now.

@lua-rocks
Copy link
Member

lua-rocks commented Apr 27, 2023

Do I understand correctly that all definitions presented in lua_api.txt but absented in client_lua_api.txt must be separated in SSM directory?

@AFCMS
Copy link
Member Author

AFCMS commented Apr 27, 2023

Yes.

@lua-rocks
Copy link
Member

I'm confused. I feel that many functions existed in lua_api.txt but missed in client_lua_api.txt should actually be there! Are helper functions table.key_value_swap(t) or math.factorial(x) available to the server only? This is very strange.

@AFCMS
Copy link
Member Author

AFCMS commented Apr 28, 2023

client_lua_api.txt is (sadly) outdated and doesn't always reflect changes made to the common APIs

To know if a function is common you can check if its defined in /builtin/common folder of minetest source code.

@lua-rocks
Copy link
Member

lua-rocks commented Apr 28, 2023

@appgurueu Hi 🤗! Can you please confirm that client_api documentation is outdated in stable 5 branch or are we missing something?

@appgurueu
Copy link

appgurueu commented Apr 28, 2023

Yes. See f.E. math.factorial. It might also be worth checking out https://github.com/minetest/minetest_docs for a few things, although mostly it only contains more in-depth docs than the Lua API.

Note that this doesn't mean that all SSM funcs are available to CSM, it just concerns the stuff defined in builtin/common as pointed out by AFCMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants