-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fp16 inference? #14
Comments
@ming053l and bellow that Is Real DRCT GAN SRx4 fully trained or we can expect more advanced model? |
hi! sorry for lately reply, we just come back from cvpr24. Actually, I haven't tried the Real-DRCT-GAN yet because, as you know, last week was a busy one. After training, I just uploaded the model directly. I will conduct a simple analysis of Real-DRCT-GAN in the coming days and upload the results to the repository. However, it will take some time and won't be completed this week. We default to using fp32, and I haven't tried fp16 inference yet. We are currently developing DRCT-v2 (an advanced version of DRCT). The design of DRCT is relatively uncomplicated, and our anticipated direction for development is to achieve better performance based on the same principles. We have already achieved some initial good results, so please look forward to future updates. Please looking forward! |
Thank you for answer. I am geting 2.5-3x speeds improvements over original pytorch code. (RTX 3090 24GB Vram) Aside from that, could you please tell me, which technique you think is the best for glueing tiles? I tried implement poisson blending but result are not always perfect. Thank you very much. |
@zelenooki87 Thank you for sharing your progress and the links! I'll add FP16 optimizations in a few days. In addition, we have developed DRCT-v2 and its parameter-size is almost 60% of DRCT-v1. At the same time, keeping the balance between performance and speed. We are preparing the document and do some experiment (cooking now...XD) Regarding tiles blending, is your purpose to accelerate inference speed and reduce artifacts as much as possible? To my best knowledge, poisson blending is common technique to use. If your want to speed up inference time, linear blending may be a good choice. Or you can try gaussian blending? I am not familar with it, so I think I can't give you a good suggestion. |
@ming053l |
@zelenooki87 Due to GPU limitations, we cannot train many models or conduct many experiments at one time. We will choose relatively important experiments to do. In terms of selection, we will prefer content that has been completed in DRCTv2 because its potential is greater than that of DRCT. As for Real-DRCT-GAN, it should not be launched in the next two weeks due to the above reasons. Thank you for the suggestions you provided us, because I personally did not have a lot of experience in training Real-SR-GAN before, and I did not consider that the training data was not comprehensive. We will use your suggestions to fine-tune Real-DRCT-GAN in the future! Training process of DRCTv2 (Blue line is version2 and red line is version1) I will add fp16 inference in these 2 day! |
@ming053l Thank you for including my script! :) It had a minor bug causing blurry output, but I've fixed it (same link, edited pastebin - https://pastebin.com/ArHEgBmR ). The output files are now as they should be. |
@ming053l |
Thank you for wonderful project.
Does model run with fp32 or with fp16 by default?
Could we force DRCT REAL Gan to use fp16 for inference?
The text was updated successfully, but these errors were encountered: