Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let DeliveryInfo internally use references or Cow #205

Open
minghuaw opened this issue May 1, 2023 · 0 comments
Open

Let DeliveryInfo internally use references or Cow #205

minghuaw opened this issue May 1, 2023 · 0 comments
Labels
breaking This would need a breaking release enhancement New feature or request

Comments

@minghuaw
Copy link
Owner

minghuaw commented May 1, 2023

In the current implementation, DeliveryInfo::from(&delivery) will clone the delivery info carried in the delivery. A Cow could probably be used to avoid this cloning. However, this is potentially a breaking change
@minghuaw minghuaw added enhancement New feature or request breaking This would need a breaking release labels May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking This would need a breaking release enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@minghuaw