Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Inconsistent type for provider configuration in config.py #1092

Open
tiaz0128 opened this issue Jan 13, 2025 · 0 comments
Open

Comments

@tiaz0128
Copy link

tiaz0128 commented Jan 13, 2025

Description

In config.py, some provider configurations are using string type while others are using tuple type. This inconsistency could lead to potential bugs and should be standardized across all providers.

Current Behavior

Some provider configurations are defined as strings while others are defined as tuples:

UPPER_WORDS = {
    # ...
    "pve": ("pve"), # Incorrectly defined as string due to single parenthesis
    "ibm": ("ibm"), # Incorrectly defined as string due to single parenthesis
    # ...
}

Expected Behavior

All provider configurations should consistently use tuple type with proper comma:

UPPER_WORDS = {
    # ...
    "pve": ("pve",), # Properly defined as tuple
    "ibm": ("ibm",), # Properly defined as tuple
    # ...
}

Why This is Important

  • Python treats ("pve") as string, not tuple
  • ("pve",) is the correct syntax for single-element tuple
  • Inconsistent types could cause bugs in code that expects tuples

Additional Context

  • Found while reviewing PR related to provider changes
  • This issue affects the configuration structure used throughout the application
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant