node v4 tests

Author: goto-bus-stop

package.json

@@ -29,6 +29,6 @@
   "scripts": {
     "prepublish": "npm run build",
     "build": "buble --output lib --target node:4 --objectAssign assign src",
-    "test": "npm run build && mocha --require buble/register && standard"
+    "test": "npm run build && mocha && standard"
   }
 }

src/index.js

@@ -1,7 +1,8 @@
+'use strict'
 const got = require('got')
 const { parse, serialize } = require('cookie')
 const props = require('promise-props')
-const assign = require('object-assign') // eslint-disable-line no-unused-vars
+const assign = require('object-assign')
 
 const DEFAULT_HOST = 'https://plug.dj'
 
@@ -42,7 +43,7 @@ function makeSessionCookieHeader (session) {
 
 function addCookieToHeaders (opts, session) {
   if (!opts.headers || !opts.headers.cookie) {
-    opts.headers = Object.assign(opts.headers || {}, {
+    opts.headers = assign(opts.headers || {}, {
       cookie: makeSessionCookieHeader(session)
     })
   }

test/test.js

@@ -1,6 +1,8 @@
 /* global describe, it, before */
+'use strict'
+
 const got = require('got')
-const { strictEqual: eq, fail, ok } = require('assert')
+const assert = require('assert')
 const login = require('../lib')
 
 const host = process.env.PLUG_LOGIN_HOST || 'https://plug.dj'
@@ -17,8 +19,8 @@ describe('plug-login', function () {
     })
   )
 
-  ok(process.env.PLUG_LOGIN_NAME, 'pass your test email in the PLUG_LOGIN_NAME env var')
-  ok(process.env.PLUG_LOGIN_PASS, 'pass your test password in the PLUG_LOGIN_PASS env var')
+  assert.ok(process.env.PLUG_LOGIN_NAME, 'pass your test email in the PLUG_LOGIN_NAME env var')
+  assert.ok(process.env.PLUG_LOGIN_PASS, 'pass your test password in the PLUG_LOGIN_PASS env var')
 
   const args = {
     email: process.env.PLUG_LOGIN_NAME,
@@ -28,39 +30,39 @@ describe('plug-login', function () {
   const INVALID_EMAIL = 'invalid-email@invalid-domain.com'
   const INVALID_PASSWORD = 'not_the_password'
   it('cannot login with invalid credentials', () =>
-    login(INVALID_EMAIL, INVALID_PASSWORD, { host }).then(fail, (result) => {
-      ok(result)
+    login(INVALID_EMAIL, INVALID_PASSWORD, { host }).then(assert.fail, (result) => {
+      assert.ok(result)
     })
   )
 
   it('can login with valid credentials', () =>
     login(args.email, args.password, { host }).then((result) => {
-      ok(result.session)
+      assert.ok(result.session)
     })
   )
 
   it('returns a cookie string that can be used for authenticated requests', () =>
     login(args.email, args.password, { host }).then((result) => {
-      ok(result.session)
+      assert.ok(result.session)
       return got(`${host}/_/users/me`, {
         headers: { cookie: result.cookie },
         json: true
       })
-    }).then(({ body }) => {
-      ok(body.data[0].id)
+    }).then((response) => {
+      assert.ok(response.body.data[0].id)
     })
   )
 
   it('can optionally retrieve an auth token', () =>
     login(args.email, args.password, { host, authToken: true }).then((result) => {
-      ok(result.session)
-      eq(typeof result.token, 'string')
+      assert.ok(result.session)
+      assert.strictEqual(typeof result.token, 'string')
     })
   )
 
   it('can retrieve auth tokens for guest users', () =>
     login.guest({ host, authToken: true }).then((result) => {
-      eq(typeof result.token, 'string')
+      assert.strictEqual(typeof result.token, 'string')
     })
   )
 
@@ -69,6 +71,6 @@ describe('plug-login', function () {
     login.user(args.email, args.password, {
       host,
       _simulateMaintenance: true
-    }).then(fail, ok)
+    }).then(assert.fail, assert.ok)
   )
 })