Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different env var names for test server host #92

Open
uuf6429 opened this issue Mar 17, 2024 · 1 comment
Open

Different env var names for test server host #92

uuf6429 opened this issue Mar 17, 2024 · 1 comment

Comments

@uuf6429
Copy link
Member

uuf6429 commented Mar 17, 2024

Shouldn't these two points use the same environment variable (at least for the port)?

if (!isset($_SERVER['WEB_FIXTURES_HOST'])) {
and
host=${MINK_HOST-localhost:8002}

In minkphp/webdriver-classic-driver#23, I was considering to use the mink-test-server script instead of calling PHP directly in the bootstrap.php file, but from what I understand it wouldn't work, unless I force MINK_HOST with:

$parsedUrl = parse_url(WebdriverClassicConfig::getInstance()->getWebFixturesUrl());
$process = new Process(..., ['MINK_HOST' => $parsedUrl['host'] . ':' . $parsedUrl['port']])`

@aik099 that's another reason I wasn't relying on the old/current (broken) approach.

@aik099
Copy link
Member

aik099 commented Mar 18, 2024

I guess different environment variables were used because nobody called the mink-test-server bash script from the PHPUnit bootstrap, where WEB_FIXTURES_HOST is also available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants