From f2b5eba9706d7a657dc1a6b5b47eb78123b80cf2 Mon Sep 17 00:00:00 2001 From: Mircea-Pavel ANTON Date: Sat, 12 Oct 2024 16:12:17 +0000 Subject: [PATCH 1/3] set the `TAP_GITHUB_TOKEN` env var --- .github/workflows/reusable-go-release.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/reusable-go-release.yaml b/.github/workflows/reusable-go-release.yaml index b445d1b..a0c7254 100644 --- a/.github/workflows/reusable-go-release.yaml +++ b/.github/workflows/reusable-go-release.yaml @@ -56,3 +56,4 @@ jobs: args: release --clean ${{ inputs.dry-run && '--snapshot' || '' }} env: GITHUB_TOKEN: "${{ steps.app-token.outputs.token }}" + TAP_GITHUB_TOKEN: "${{ steps.app-token.outputs.token }}" From ae84d88314d91ef41706cae5a75a2f142a4d30ea Mon Sep 17 00:00:00 2001 From: Mircea-Pavel ANTON Date: Sat, 12 Oct 2024 16:46:23 +0000 Subject: [PATCH 2/3] try PAT? --- .github/workflows/reusable-go-release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-go-release.yaml b/.github/workflows/reusable-go-release.yaml index a0c7254..ccd19b5 100644 --- a/.github/workflows/reusable-go-release.yaml +++ b/.github/workflows/reusable-go-release.yaml @@ -56,4 +56,4 @@ jobs: args: release --clean ${{ inputs.dry-run && '--snapshot' || '' }} env: GITHUB_TOKEN: "${{ steps.app-token.outputs.token }}" - TAP_GITHUB_TOKEN: "${{ steps.app-token.outputs.token }}" + TAP_GITHUB_TOKEN: "${{ secrets.GHCR_RW_TOKEN }}" From c67f086c047abf6be9ab6d78b9940473ef76238c Mon Sep 17 00:00:00 2001 From: Mircea-Pavel ANTON Date: Sat, 12 Oct 2024 16:51:06 +0000 Subject: [PATCH 3/3] add fixme comment --- .github/workflows/reusable-go-release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-go-release.yaml b/.github/workflows/reusable-go-release.yaml index ccd19b5..f518c7d 100644 --- a/.github/workflows/reusable-go-release.yaml +++ b/.github/workflows/reusable-go-release.yaml @@ -56,4 +56,4 @@ jobs: args: release --clean ${{ inputs.dry-run && '--snapshot' || '' }} env: GITHUB_TOKEN: "${{ steps.app-token.outputs.token }}" - TAP_GITHUB_TOKEN: "${{ secrets.GHCR_RW_TOKEN }}" + TAP_GITHUB_TOKEN: "${{ secrets.GHCR_RW_TOKEN }}" # FIXME: maybe figure out how to make this work with the github app token...